New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644430 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove CHANNEL_AUTH_TYPE_SSL

Project Member Reported by btolsch@chromium.org, Sep 6 2016

Issue description

CHANNEL_AUTH_TYPE_SSL, defined by extensions/common/api/cast_channel/logging.proto, doesn't seem to have any use outside of tests.  It should be removed if it isn't required by anything else.


 

Comment 1 by sko...@chromium.org, Sep 21 2016

Labels: Hotlist-Fixit
Status: Available (was: Untriaged)

Comment 2 by scf@chromium.org, Dec 5 2016

Owner: scf@chromium.org

Comment 3 by scf@chromium.org, Dec 5 2016

Status: (was: Available)
@btosch: Do you mind pointing to where this is defined? Its not in https://cs.chromium.org/chromium/src/extensions/common/api/cast_channel/logging.proto
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d144584589a46a1872f07732d587e6cf60c7a787

commit d144584589a46a1872f07732d587e6cf60c7a787
Author: scf <scf@chromium.org>
Date: Tue Dec 13 03:45:54 2016

remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG= 644430 

Review-Url: https://codereview.chromium.org/2559283003
Cr-Commit-Position: refs/heads/master@{#438040}

[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/common.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/test_get_logs.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/test_open_receive_close.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/test_open_send_close.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/chrome/test/data/extensions/api_test/cast_channel/api/test_open_timeout.js
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/cast_channel_api_unittest.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/cast_channel_apitest.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/cast_socket.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/browser/api/cast_channel/logger.cc
[modify] https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787/extensions/common/api/cast_channel.idl

Labels: -Hotlist-Fixit Hotlist-CodeHealth
Status: Fixed
This should be fixed since I don't see any more references to CHANNEL_AUTH_TYPE_SSL in the codebase. Please reopen if that is not the case. 

Sign in to add a comment