New issue
Advanced search Search tips

Issue 644425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 597756



Sign in to add a comment

Add visual indicator for Blimp tabs

Project Member Reported by nyquist@chromium.org, Sep 6 2016

Issue description

Whenever Blimp tabs are loaded, there is no visual indicator that this tab is a Blimp tab. There is also no visual indicator as to whether a new tab will be a blimp tab or not.

Some visual indicator should be added to ensure that it is possible for users to identify the (currently only) tab holding a BlimpContents.

The simplest fix would probably be to just use a specific theme color for blimp tabs. You can look here:
https://chromium.googlesource.com/chromium/src/+/e942099e4a004adb1a7720282327bcabd8f27d72/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java#1097

We probably want to still be able to run the security-related code, etc., so following what we do for WebContents and do something similar would probably be good. We would ask the BlimpContents for the theme color so that we can ensure that when we later pipe the data through from the engine, we will use the theme color from the site.
 
Status: Fixed (was: Untriaged)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/b2e5b44429452386be1908bdad73ed5df0fa0b14

commit b2e5b44429452386be1908bdad73ed5df0fa0b14
Author: xingliu <xingliu@chromium.org>
Date: Wed Sep 07 22:10:23 2016

Add theme color for Blimp on Android.

Use Material Design color Light Blue 100 for a Blimp tab.
See https://material.google.com/style/color.html for details.

BUG= 64425 

Review-Url: https://codereview.chromium.org/2315953002
Cr-Commit-Position: refs/heads/master@{#417079}

[modify] blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java
[modify] blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java
[modify] chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
Labels: Archive-Blimp

Sign in to add a comment