New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644420 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Crash in HandleBZ2

Project Member Reported by ClusterFuzz, Sep 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6432518603800576

Fuzzer: libfuzzer_safe_browsing_dmg_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x000000000000
Crash State:
  HandleBZ2
  safe_browsing::dmg::UDIFBlockChunkReadStream::Read
  safe_browsing::dmg::UDIFPartitionReadStream::Read
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=416613:416614

Minimized Testcase (7.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96aX3_In-c-_Yv9AC1-4jbes_uGMtAdTXZ39QGgPvJ_oyTwHJxm7TQdcYHgokzsCxtRPj3Uc93FIm3-WiOI-kpGYQYv5_DwaVFQ-omxMF1xFRb4oBlFul7hpN8iOWwcDKuI--wHJ5sjiBntg-kGHMOUxjuJ8Q?testcase_id=6432518603800576

Issue manually filed by: mmohammad

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
rsesek @ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !
The problem is that length_in_bytes_ is pathologically large, and so this is actually just a failure to allocate.

(lldb) p *this
(safe_browsing::dmg::(anonymous namespace)::UDIFBlockChunkReadStream) $2 = {
  stream_ = 0x00007fff5fbfe5f0
  chunk_ = 0x0000000102900270
  length_in_bytes_ = 2286984186822656
  offset_ = 1024
  decompress_buffer_ = size=0 {}
  did_decompress_ = false
}
(lldb) p *chunk_
(const safe_browsing::dmg::UDIFBlockChunk) $4 = {
  type = 2147483654
  comment = 0
  start_sector = 0
  sector_count = 4466765989888
  compressed_offset = 0
  compressed_length = 1245
}

The problem is that in UDIFBlockChunkReadStream::HandleBZ2, we want to allocate the full decompress_buffer_ for the full length_in_bytes_.

Comment 3 by rsesek@chromium.org, Sep 15 2016

Labels: -Pri-1 Pri-2
Project Member

Comment 4 by ClusterFuzz, Oct 6 2016

ClusterFuzz has detected this issue as fixed in range 423384:423408.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6432518603800576

Fuzzer: libfuzzer_safe_browsing_dmg_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x000000000000
Crash State:
  HandleBZ2
  safe_browsing::dmg::UDIFBlockChunkReadStream::Read
  safe_browsing::dmg::UDIFPartitionReadStream::Read
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=416613:416614
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=423384:423408

Minimized Testcase (7.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96aX3_In-c-_Yv9AC1-4jbes_uGMtAdTXZ39QGgPvJ_oyTwHJxm7TQdcYHgokzsCxtRPj3Uc93FIm3-WiOI-kpGYQYv5_DwaVFQ-omxMF1xFRb4oBlFul7hpN8iOWwcDKuI--wHJ5sjiBntg-kGHMOUxjuJ8Q?testcase_id=6432518603800576

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 6 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 6 by rsesek@chromium.org, Oct 12 2016

Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Status: Assigned (was: Verified)

Comment 7 by rsesek@chromium.org, Oct 12 2016

Cc: rsesek@chromium.org
 Issue 654942  has been merged into this issue.

Comment 8 by rsesek@chromium.org, Nov 15 2016

 Issue 665268  has been merged into this issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: aizatsky@chromium.org msrchandra@chromium.org mmoroz@chromium.org kcc@chromium.org
 Issue 637111  has been merged into this issue.
Status: WontFix (was: Assigned)
Bulk-WontFixing these bugs. This was a bug on ClusterFuzz side, see bug 717534. We will start seeing new testcases auto-filed in a day or two. We can't leave these open as ClusterFuzz won't autoverify them after ClusterFuzz-Wrong label.
Project Member

Comment 12 by ClusterFuzz, Jul 14 2017

Labels: Needs-Feedback
ClusterFuzz testcase 4667373761331200 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment