New issue
Advanced search Search tips

Issue 644417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 597756



Sign in to add a comment

Fix UI touch offset for Blimp

Project Member Reported by nyquist@chromium.org, Sep 6 2016

Issue description

The current version of blimp does not correctly offset the toolbar, so all touches are off by the height of the toolbar, making it hard to touch targets. We should ensure that the touch offsets are done correctly, similarly to ContentViewCore: https://chromium.googlesource.com/chromium/src/+/e942099e4a004adb1a7720282327bcabd8f27d72/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#1646
 
Labels: -Pri-3 M-55 OS-Android Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d46c208114822ce0d06961e8ea4c60dc44443b0a

commit d46c208114822ce0d06961e8ea4c60dc44443b0a
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu Sep 08 07:23:32 2016

Fixed touch offset for Blimp

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG= 644417 

Review-Url: https://codereview.chromium.org/2319913002
Cr-Commit-Position: refs/heads/master@{#417218}

[modify] https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
[modify] https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java
[modify] https://crrev.com/d46c208114822ce0d06961e8ea4c60dc44443b0a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Labels: Archive-Blimp

Sign in to add a comment