New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644407 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Sep 2016
Cc:
█ w...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android's default isolates no longer exist, but test_runner.py still tries to use them

Project Member Reported by w...@chromium.org, Sep 6 2016 
* ninja -C out/a content_browsertests
* build/android/test_runner.py gtest -s content_browsertests --output-directory out/a -f 'MediaTest*'

This runs into an error when it tries to read the deleted content/content_browsertests.isolate.

It works if you add --isolate-file-path=out/a/./gen.runtime/content/test/content_browsertests.device.isolate

Comment 1 by jbudorick@chromium.org, Sep 6 2016

Status: Assigned (was: Available)
Summary: Android's default isolates no longer exist, but test_runner.py still tries to use them (was: Android content_browsertests don't find the default isolate )
Please use ./out/a/bin/run_content_browsertests -f 'MediaTest*'.

The default checked-in isolates are no longer valid defaults. I'll delete them and revise the error messaging.

Comment 2 by w...@chromium.org, Sep 6 2016 

Ah, thanks for the tip
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824469272d7ec1a122036feaadf5cc8a4dc298f7

commit 824469272d7ec1a122036feaadf5cc8a4dc298f7
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Sep 09 20:09:04 2016

[Android] Remove support for default isolates in the test runner.

The checked-in .isolate files don't exist any more.

BUG= 644407 

Review-Url: https://codereview.chromium.org/2322503005
Cr-Commit-Position: refs/heads/master@{#417681}

[modify] https://crrev.com/824469272d7ec1a122036feaadf5cc8a4dc298f7/build/android/pylib/gtest/gtest_test_instance.py

Comment 4 by jbudorick@chromium.org, Sep 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment