mtools build fails w/clang |
||||||||
Issue description
looks like clang is unhappy with the attribute unused syntax
x86_64-cros-linux-gnu-gcc -DHAVE_CONFIG_H -DSYSCONFDIR=\"/etc/mtools\" -DCPU_x86_64 -DVENDOR_cros -DOS_linux_gnu -O2 -pipe -O2 -pipe -march=x86-64 -msse3 -g -fn
o-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -Wall -fno-strict-aliasing -I. -I. -c mainloop.c
mainloop.c:89:15: error: expected ')'
int unix_loop(UNUSED(Stream_t *Stream), MainParam_t *mp, char *arg,
^
./sysincludes.h:106:47: note: expanded from macro 'UNUSED'
# define UNUSED(x) x __attribute__ ((unused));x
^
,
Sep 29 2016
,
Oct 4 2016
,
Mar 9 2017
,
Mar 10 2017
staring at that error message again and it's kind of obvious why it's failing -- it's sticking a semi-colon in there when it shouldn't. i'll post some patches.
,
Mar 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/cd57ab041601c8a0335fe38315388220f777527b commit cd57ab041601c8a0335fe38315388220f777527b Author: Mike Frysinger <vapier@chromium.org> Date: Sat Mar 11 03:52:33 2017 mtools: update to 4.0.18-r2 for clang fixes BUG= chromium:644387 TEST=`emerge-amd64-generic mtools` works w/clang Change-Id: I33d96b9a8bb37836e062ed0afadaa677dde5776f Reviewed-on: https://chromium-review.googlesource.com/452160 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [rename] https://crrev.com/cd57ab041601c8a0335fe38315388220f777527b/sys-fs/mtools/mtools-4.0.18-r2.ebuild [add] https://crrev.com/cd57ab041601c8a0335fe38315388220f777527b/sys-fs/mtools/files/mtools-4.0.18-attr.patch [add] https://crrev.com/cd57ab041601c8a0335fe38315388220f777527b/sys-fs/mtools/files/mtools-4.0.18-memset.patch
,
Mar 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9a636e6bb98b9174eaf6d2bdead5e6a168dd2a02 commit 9a636e6bb98b9174eaf6d2bdead5e6a168dd2a02 Author: Mike Frysinger <vapier@chromium.org> Date: Sun Mar 12 05:21:31 2017 mtools: build with clang We've fixed the errors in the source so it works with clang now. BUG= chromium:644387 TEST=precq passes CQ-DEPEND=CL:452160 Change-Id: I310bde62d4f0acd382eacdf799d5bcc7126d70f3 Reviewed-on: https://chromium-review.googlesource.com/452321 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [delete] https://crrev.com/3f259bf3dae9f2e247c85124724fdf69d15623a9/chromeos/config/env/sys-fs/mtools
,
Mar 12 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016