New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644377 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 646094



Sign in to add a comment

PathUtils should use application context

Project Member Reported by wnwen@chromium.org, Sep 6 2016

Issue description

PathUtils should use the application context rather than have the caller pass in context in PathUtils#setPrivateDataDirectorySuffix. This ensures that we correctly initialize ContextUtils correctly everywhere PathUtils is used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41

commit 9c8dc6d2170f138ce81f195b6ffa0da3b046bd41
Author: wnwen <wnwen@chromium.org>
Date: Thu Sep 08 13:32:12 2016

Clean up PathUtils unused parameters.

The context parameters are no longer necessary for PathUtils.

BUG= 644377 

Review-Url: https://codereview.chromium.org/2318493003
Cr-Commit-Position: refs/heads/master@{#417272}

[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/ResourceExtractor.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/library_loader/ModernLinker.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/path_utils.cc
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41

commit 9c8dc6d2170f138ce81f195b6ffa0da3b046bd41
Author: wnwen <wnwen@chromium.org>
Date: Thu Sep 08 13:32:12 2016

Clean up PathUtils unused parameters.

The context parameters are no longer necessary for PathUtils.

BUG= 644377 

Review-Url: https://codereview.chromium.org/2318493003
Cr-Commit-Position: refs/heads/master@{#417272}

[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/ResourceExtractor.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/java/src/org/chromium/base/library_loader/ModernLinker.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/base/android/path_utils.cc
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java
[modify] https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41/components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java

Comment 3 by wnwen@chromium.org, Sep 12 2016

Blocking: 646094
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7200e9f34aa2e9006d8ea5540035de744b13d27d

commit 7200e9f34aa2e9006d8ea5540035de744b13d27d
Author: wnwen <wnwen@chromium.org>
Date: Thu Oct 06 19:38:58 2016

Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG= 644377 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2333713003
Cr-Commit-Position: refs/heads/master@{#423633}

[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java

Comment 5 by wnwen@chromium.org, Oct 6 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb262f964b4a158be02b5497462e2e8d170a59b

commit 5cb262f964b4a158be02b5497462e2e8d170a59b
Author: sgurun <sgurun@chromium.org>
Date: Tue Oct 11 02:36:20 2016

Fix monochrome not booting issue

Revert these two CLs to have monochrome working again on ToT.

Revert "Move PathUtils to use ContextUtils."
 commit 7200e9f34aa2e9006d8ea5540035de744b13d27d.
Revert "Reland of Move language pak files to assets."
 commit 67101cd0338a409d80689b9c9c875c95ccde7957.

BUG=653771, 644377 ,  529604 

TBR==agrieve@chromium.org,tedchoc@chromium.org,slan@chromium.org,xunjieli@chromium.org,torne@chromium.org,nyquist@chromium.org,wnwen@chromium.org, michaelbai@chomium.org, estevenson@chromium.org

Review-Url: https://codereview.chromium.org/2406093002
Cr-Commit-Position: refs/heads/master@{#424345}

[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/BUILD.gn
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/test/BUILD.gn
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/base/android/java/src/org/chromium/base/LocaleUtils.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/base/android/java/src/org/chromium/base/ResourceExtractor.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java
[add] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/build/android/gyp/locale_pak_resources.py
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/build/android/gyp/write_build_config.py
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/build/android/resource_sizes.py
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/build/config/android/internal_rules.gni
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/build/config/android/rules.gni
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/BUILD.gn
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/public/android/java/src/org/chromium/content/app/ContentApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java
[modify] https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11 2016

Labels: merge-merged-2887
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b13fb748260bd09d0e9872fb3fbe09a5208d451

commit 1b13fb748260bd09d0e9872fb3fbe09a5208d451
Author: Alex Mineer <amineer@chromium.org>
Date: Tue Oct 11 03:27:50 2016

Fix monochrome not booting issue

Revert these two CLs to have monochrome working again on ToT.

Revert "Move PathUtils to use ContextUtils."
 commit 7200e9f34aa2e9006d8ea5540035de744b13d27d.
Revert "Reland of Move language pak files to assets."
 commit 67101cd0338a409d80689b9c9c875c95ccde7957.

BUG=653771, 644377 ,  529604 

TBR==agrieve@chromium.org,tedchoc@chromium.org,slan@chromium.org,xunjieli@chromium.org,torne@chromium.org,nyquist@chromium.org,wnwen@chromium.org, michaelbai@chomium.org, estevenson@chromium.org

(cherry picked from commit 5cb262f964b4a158be02b5497462e2e8d170a59b)

Review-Url: https://codereview.chromium.org/2406093002
Cr-Original-Commit-Position: refs/heads/master@{#424345}
Cr-Commit-Position: refs/branch-heads/2887@{#2}
Cr-Branched-From: 731c9896052c3824ec4630a1461738ecbccb16b5-refs/heads/master@{#424315}

[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/BUILD.gn
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/test/BUILD.gn
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/base/android/java/src/org/chromium/base/LocaleUtils.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/base/android/java/src/org/chromium/base/ResourceExtractor.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java
[add] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/build/android/gyp/locale_pak_resources.py
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/build/android/gyp/write_build_config.py
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/build/android/resource_sizes.py
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/build/config/android/internal_rules.gni
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/build/config/android/rules.gni
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/BUILD.gn
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/public/android/java/src/org/chromium/content/app/ContentApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java
[modify] https://crrev.com/1b13fb748260bd09d0e9872fb3fbe09a5208d451/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89f4819881bab4bed97982bf1d52367b7d6e3314

commit 89f4819881bab4bed97982bf1d52367b7d6e3314
Author: wnwen <wnwen@chromium.org>
Date: Tue Oct 11 17:40:49 2016

Reland "Move PathUtils to use ContextUtils."

Revert for another issue required reverting original CL:
https://codereview.chromium.org/2333713003/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
BUG= 644377 ,653711
TBR=slan@chromium.org,torne@chromium.org,agrieve@chromium.org,xunjieli@chromium.org,tedchoc@chromium.org,nyquist@chromium.org

Review-Url: https://codereview.chromium.org/2412623002
Cr-Commit-Position: refs/heads/master@{#424474}

[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/89f4819881bab4bed97982bf1d52367b7d6e3314/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d

commit 732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d
Author: agrieve <agrieve@chromium.org>
Date: Fri Oct 14 18:49:13 2016

Reland #2 of Move language pak files to assets

Reverted in:
https://codereview.chromium.org/2406093002/
and https://codereview.chromium.org/2404043002

Reason for reland:
Now auto-detects whether locale paks are compressed or stored
(for chrome, but not webview)

TBR=michaelbai
BUG=653771, 644377 ,  529604 

Review-Url: https://codereview.chromium.org/2404253003
Cr-Commit-Position: refs/heads/master@{#425402}

[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/android_webview/BUILD.gn
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/android_webview/test/BUILD.gn
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/base/android/java/src/org/chromium/base/LocaleUtils.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/base/android/java/src/org/chromium/base/ResourceExtractor.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java
[delete] https://crrev.com/633c166bf730a58a847a6705c46ec08989a74db0/build/android/gyp/locale_pak_resources.py
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/build/android/gyp/write_build_config.py
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/build/android/resource_sizes.py
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/build/config/android/internal_rules.gni
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/build/config/android/rules.gni
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/chrome/android/BUILD.gn
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[delete] https://crrev.com/633c166bf730a58a847a6705c46ec08989a74db0/chrome/android/monochrome_repack_locales.gni
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/content/public/android/java/src/org/chromium/content/app/ContentApplication.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/732f0d89ca9c435e2bddfcfcdb9b108fb9b7ac0d/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7200e9f34aa2e9006d8ea5540035de744b13d27d

commit 7200e9f34aa2e9006d8ea5540035de744b13d27d
Author: wnwen <wnwen@chromium.org>
Date: Thu Oct 06 19:38:58 2016

Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG= 644377 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2333713003
Cr-Commit-Position: refs/heads/master@{#423633}

[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
[modify] https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment