New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644347 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 640401



Sign in to add a comment

crosh integration for managing containers

Project Member Reported by hannia@google.com, Sep 6 2016

Issue description

crosh integration
 
Blockedon: 640401
Labels: OS-Chrome
Owner: vapier@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: crosh integration for managing containers (was: crosh integration)
i've got most of the framework logic landing via  issue 640401 .  have to refine/check the autotests before finishing it.

otherwise, pending CL is here:
https://chromium-review.googlesource.com/362122
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 7 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d653dbab6abdbaef60081f7be2cb48392a125742

commit d653dbab6abdbaef60081f7be2cb48392a125742
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Apr 03 20:49:56 2017

container_utils: add program to mount image

This small program calls into imageloader to register and load
a component, which is a rootfs image run_oci understands.

BUG= chromium:644347 
TEST=mount_extension_image --name=adb on device with adb
  container extension in user extensions directory

Change-Id: I4ad2f0b8eea30ee9de26035ed14137840b4e3473
Reviewed-on: https://chromium-review.googlesource.com/458563
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/d653dbab6abdbaef60081f7be2cb48392a125742/container_utils/container_utils.gyp
[add] https://crrev.com/d653dbab6abdbaef60081f7be2cb48392a125742/container_utils/mount_extension_image.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/86b53b0017cbb559a9e577caed73c69d4a0356ec

commit 86b53b0017cbb559a9e577caed73c69d4a0356ec
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Apr 06 23:01:44 2017

container_utils: add mount_extension_image binary

This installs the binary that mounts container images out of
your extensions directory.

CQ-DEPEND=CL:458563
BUG= chromium:644347 
TEST=emerge

Change-Id: I6360cc7c00869d74d4e8e3bffd47b9f1e8aaaebe
Reviewed-on: https://chromium-review.googlesource.com/458736
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/86b53b0017cbb559a9e577caed73c69d4a0356ec/chromeos-base/container_utils/container_utils-9999.ebuild

Cc: ejcaruso@chromium.org
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/c12e11485aac8e59476a40ae3df7a78c2a54bacd

commit c12e11485aac8e59476a40ae3df7a78c2a54bacd
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 18 02:06:28 2017

package_to_container: switch to container.json

We need to look for a file with a different name than "manifest.json"
because the CWS does not let us upload extensions with more than one
(the main one), and we want to support more than one, and we want to
use our own format rather than try to merge with the Chrome API.

BUG= chromium:644347 
TEST=creating a new container used container.json

Change-Id: I16de61a8546422688fd7463aed7d5c0ffec6e450
Reviewed-on: https://chromium-review.googlesource.com/506752
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/c12e11485aac8e59476a40ae3df7a78c2a54bacd/package_to_container

Project Member

Comment 8 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b5cdb923326276db6a3c7d06b3ff9156bcf0bec6

commit b5cdb923326276db6a3c7d06b3ff9156bcf0bec6
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 18 02:06:28 2017

container_utils: rework extension searching

Use the cryptohome APIs to locate active user sessions and their home
directories instead of hardcoding any paths.

Further, change how we walk the Extensions dir.  We need to look for a
file with a different name than "manifest.json" because the CWS does not
let us upload extensions with more than one (the main one), and we want
to support more than one, and we want to use our own format rather than
try to merge with the Chrome API.

BUG= chromium:644347 
TEST=mount_extension_image --name=adb on device with a logged in user and an installed extension

Change-Id: I88109717d4707909b69cdd9740e87593a3ece715
Reviewed-on: https://chromium-review.googlesource.com/505717
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/b5cdb923326276db6a3c7d06b3ff9156bcf0bec6/container_utils/container_utils.gyp
[modify] https://crrev.com/b5cdb923326276db6a3c7d06b3ff9156bcf0bec6/container_utils/mount_extension_image.cc

Comment 9 by vapier@chromium.org, May 18 2017

Labels: -Restrict-View-Google
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b

commit 8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 05:12:33 2017

container_utils: fix inverted logic

Some last minute refactor request broke this.

BUG= chromium:644347 
TEST=`c adb` in crosh can find the extension again

Change-Id: If29911ca1d454332a81986a9c56b6f6f33cdd7c1
Reviewed-on: https://chromium-review.googlesource.com/513442
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b/container_utils/mount_extension_image.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b

commit 8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 05:12:33 2017

container_utils: fix inverted logic

Some last minute refactor request broke this.

BUG= chromium:644347 
TEST=`c adb` in crosh can find the extension again

Change-Id: If29911ca1d454332a81986a9c56b6f6f33cdd7c1
Reviewed-on: https://chromium-review.googlesource.com/513442
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b/container_utils/mount_extension_image.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b

commit 8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 05:12:33 2017

container_utils: fix inverted logic

Some last minute refactor request broke this.

BUG= chromium:644347 
TEST=`c adb` in crosh can find the extension again

Change-Id: If29911ca1d454332a81986a9c56b6f6f33cdd7c1
Reviewed-on: https://chromium-review.googlesource.com/513442
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8527ec8fc1df06c4492aa7f7a23e1cec8fdde84b/container_utils/mount_extension_image.cc

Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: OS>Systems>Containers
Status: Fixed (was: Archived)

Sign in to add a comment