Files app completes in-progress rename attempt when losing focus |
||||||||
Issue descriptionChrome Version: 52.0.2743.116 OS Version: 8350.68.0 1. Open the Files app. 2. Right-click on a file and select "Rename". 3. Hit Alt-Tab to focus another window. 4. Hit Alt-Tab to refocus the Files app. I'd expect to still be editing the filename, but it looks like we rename the file as soon as the Files app loses can focus. This is problematic when I focus a different window so that I could copy text from it (timestamp, bug number, etc.) to paste into the filename. Unless there's a good reason not to, we should probably not perform the rename action until the user actually hits Enter or clicks elsewhere in the Files app window. (I'm not sure who's PM-ing the app now.)
,
Feb 6 2018
This issue reproduces even by hitting <Tab> in step 3. We should revert the rename operation when the input loses focus.
,
Feb 6 2018
Instead of canceling the rename, can we instead keep the edit operation in-progress until I either click elsewhere in the Files window or hit Enter? In the original report, I changed the focus so I could copy a bug number into the filename, so if we cancel the rename on focus loss, that doesn't help much.
,
Feb 6 2018
I think it is doable. IIUC, the expected behavior here is: 1) When an input box for renaming file lose focus => Cancel renaming. 2) When Files app window lose focus => Keep the input box focused and keep the rename operation in-progress.
,
Feb 6 2018
Thanks! And yes, that matches my expectations for how this would behave.
,
Feb 22 2018
<files-triage>
,
Feb 28 2018
,
Nov 7
,
Nov 18
The current behaviour is mostly consistent with Explorer, Finder and Konqueror. Losing focus (except by pressing escape) in all of those results in the rename completing. Nautilus pops up a bubble for the rename that does persist across loss of focus to its parent window. The behaviour of pressing tab differs: - Explorer completes the rename and starts renaming the next file - Finder completes the rename - Konqueror inserts a tab - Nautilus moves focus between the text field and the rename button Matching most other file managers seems a reasonable choice.
,
Nov 18
I described a frustrating user experience that's caused by the current behavior. Does it have any advantages that I'm not thinking of?
,
Nov 19
Consistency with other GUI file manager apps that are likely to be familiar.
,
Nov 19
,
Dec 3
Weifang, over to you for triage per Chrome OS UI review. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by weifangsun@chromium.org
, Nov 15 2016Status: Assigned (was: Untriaged)