In preparation for removing the Blimp split from within the compositor proxies, reduce the BlimpCompositor class to a thin wrapper on the LayerTreeHost. This will then be replaced with the RemoteCompositor which will live in cc/blimp.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/065a2ac30957724ecc1330beae316087c96b7093 commit 065a2ac30957724ecc1330beae316087c96b7093 Author: khushalsagar <khushalsagar@chromium.org> Date: Wed Sep 07 17:16:08 2016 cc/blimp: Remove the LayerTreeSettings serialization. The code is unused, the client always builds the settings locally which is necessary because they are platform/device specific. The eventual plan is to build them on the client using the same code as the RenderWidgetCompositor. The next change will remove the Initialize and Close messages altogether. BUG= 577985 , 644326 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2314933004 Cr-Commit-Position: refs/heads/master@{#416975} [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/blimp/client/core/compositor/blimp_compositor.cc [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/blimp/client/core/compositor/blimp_compositor.h [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/blimp/client/core/compositor/blimp_compositor_unittest.cc [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/BUILD.gn [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/proto/BUILD.gn [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/proto/compositor_message_to_impl.proto [delete] https://crrev.com/fb84b3b9087d1836e5b00773dbc5b280d4b5f1d8/cc/proto/layer_tree_settings.proto [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/test/layer_tree_test.cc [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/trees/layer_tree_settings.cc [delete] https://crrev.com/fb84b3b9087d1836e5b00773dbc5b280d4b5f1d8/cc/trees/layer_tree_settings_unittest.cc [modify] https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093/cc/trees/remote_channel_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149 commit b86a1b2ea9d1feb73cc11b819cecaca35b6a9149 Author: khushalsagar <khushalsagar@chromium.org> Date: Fri Sep 09 00:36:28 2016 cc/blimp: Remove Initialize and Close messages. The BlimpCompositor has a 1:1 mapping with the RenderWidgetCompositor, there is no need for explicit create methods for the LayerTreeHost. Next change will pull blimp specific code from BlimpCompositor to a higher layer. BUG= 644326 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2320823003 Cr-Commit-Position: refs/heads/master@{#417453} [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/blimp/client/core/compositor/blimp_compositor.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/blimp/client/core/compositor/blimp_compositor.h [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/blimp/client/core/compositor/blimp_compositor_manager_unittest.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/blimp/client/core/compositor/blimp_compositor_unittest.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/proto/compositor_message_to_impl.proto [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/test/layer_tree_test.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/test/layer_tree_test.h [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/test/remote_proto_channel_bridge.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/test/remote_proto_channel_bridge.h [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/test/test_hooks.h [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/trees/remote_channel_impl.cc [modify] https://crrev.com/b86a1b2ea9d1feb73cc11b819cecaca35b6a9149/cc/trees/remote_channel_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78db80d1a9953c01fe68f94adee0f4460cb2caf commit d78db80d1a9953c01fe68f94adee0f4460cb2caf Author: xingliu <xingliu@chromium.org> Date: Thu Oct 06 19:33:42 2016 Add BlimpDocument, pull out functions in BlimpCompositor. Previously BlimpCompositor is heavy weight class that also include render_widget_id and input manager, and we have the following ownership: BlimpContentImpl -> BlimpCompositorManager -> BlimpCompositor. This CL: 1. Rename BlimpCompositorManager to BlimpDocumentManager. 2. Add BlimpDocument, which owns a BlimpCompositor. It matches the idea of helium document. So more feature with document scope can goes in this layer. 3. Unit test for new class, and also rename old unit tests. The ownership chains now become the following: BlimpContentImpl->BlimpDocumentManager->BlimpDocument->BlimpCompositor. BUG= 644326 Review-Url: https://codereview.chromium.org/2382733007 Cr-Commit-Position: refs/heads/master@{#423629} [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/app/android/blimp_view.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/app/android/blimp_view.h [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/compositor/BUILD.gn [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/compositor/blimp_compositor.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/compositor/blimp_compositor.h [delete] https://crrev.com/c40fd6db914d615bf451f69efaa9af8d8a87777c/blimp/client/core/compositor/blimp_compositor_manager.cc [delete] https://crrev.com/c40fd6db914d615bf451f69efaa9af8d8a87777c/blimp/client/core/compositor/blimp_compositor_manager.h [delete] https://crrev.com/c40fd6db914d615bf451f69efaa9af8d8a87777c/blimp/client/core/compositor/blimp_compositor_manager_unittest.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/compositor/blimp_compositor_unittest.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/contents/BUILD.gn [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/contents/android/blimp_view.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/contents/blimp_contents_impl.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/contents/blimp_contents_impl.h [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/contents/blimp_contents_view_impl.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/feedback/blimp_feedback_data.cc [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/BUILD.gn [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document.cc [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document.h [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document_manager.cc [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document_manager.h [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document_manager_unittest.cc [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/blimp_document_unittest.cc [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/mock_render_widget_feature.cc [add] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/mock_render_widget_feature.h [modify] https://crrev.com/d78db80d1a9953c01fe68f94adee0f4460cb2caf/blimp/client/core/render_widget/render_widget_feature.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f899472e1c9bf5487449603df5a6584f22b8068d commit f899472e1c9bf5487449603df5a6584f22b8068d Author: xingliu <xingliu@chromium.org> Date: Tue Oct 11 02:11:03 2016 Move BlimpInputManager to BlimpDocument from BlimpCompositor. Previously BlimpCompositor also routes the input events, And we have the following call chain: UI->BlimpInputManager->BlimpCompositor->BlimpDocument-> BlimpDocumentManager->RenderWidgetFeature. This CL moves the ownership of BlimpInputManager to BlimpDocument, the call chain of sending input event to engine becomes: UI->BlimpInputManager->BlimpDocument->BlimpDocumentManager-> RenderWidgetFeature. BUG= 644326 Review-Url: https://codereview.chromium.org/2400923002 Cr-Commit-Position: refs/heads/master@{#424343} [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/compositor/BUILD.gn [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/compositor/blimp_compositor.cc [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/compositor/blimp_compositor.h [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/compositor/blimp_compositor_unittest.cc [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/BUILD.gn [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document.cc [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document.h [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document_manager.cc [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document_manager.h [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document_manager_unittest.cc [modify] https://crrev.com/f899472e1c9bf5487449603df5a6584f22b8068d/blimp/client/core/render_widget/blimp_document_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016