New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644304 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add policy for login screen apps

Project Member Reported by emaxx@chromium.org, Sep 6 2016

Issue description

Admin policy for login screen apps should be added.

Currently, even with the work tracked in issue 576464, there would be no way for the admins to push configuration for the login screen apps. Given that the login screen apps would be disallowed to show any UI, having an ability to push the policy for them is crucial.

This should be probably done in a way similar to how policy for extensions currently work under user profiles: the user policy contains references to the separate JSON blobs containing the policy contents. But for the login screen apps, the device policy should be used instead.
 

Comment 1 by emaxx@chromium.org, Sep 6 2016

Owner: emaxx@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae

commit f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae
Author: emaxx <emaxx@chromium.org>
Date: Mon Oct 31 22:34:17 2016

Add policy domain for signin screen apps

This introduces a new policy domain that is intended for fetching and
providing admin policies for the login screen apps.

This is preparation CL for the following CLs that will add actual
fetching of the policies for the login screen apps.

No behavior change is expected to be introduced by this CL.

BUG= 644304 
TEST=existing tests

Review-Url: https://codereview.chromium.org/2440473004
Cr-Commit-Position: refs/heads/master@{#428845}

[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/chromeos/policy/device_local_account_extension_tracker.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/extensions/api/storage/managed_value_store_cache.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/policy/test/local_policy_test_server.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/chrome/browser/policy/test/policy_testserver.py
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/cloud_policy_constants.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/cloud_policy_constants.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/cloud_policy_manager.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/cloud_policy_manager.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/component_cloud_policy_service.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/component_cloud_policy_service.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/component_cloud_policy_service_stub.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/resource_cache.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/policy_namespace.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/policy_service_impl_unittest.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/policy_test_utils.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/schema_registry.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/schema_registry.h
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
[modify] https://crrev.com/f1884f8297f6c1c4d1f3a67d8271fd1d1c7385ae/components/policy/core/common/schema_registry_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6660a9d0880ad8cc3847fba07d98ef1f05d3869b

commit 6660a9d0880ad8cc3847fba07d98ef1f05d3869b
Author: emaxx <emaxx@chromium.org>
Date: Thu Nov 03 17:34:37 2016

Fix behavior of cloud policy refreshes scheduled for soon

The CloudPolicyRefreshScheduler class was implemented in such a way
that refreshes scheduled for soon using the RefreshSoon method could
be actually overridden by subsequent changes resulting in re-scheduling
of the refresh.

As an example of case which would result in ignoring a soon refresh is the OnStoreLoaded observer called when there's a non-empty response map in the policy client. This observer in this case would update the last_refresh_ field when it's empty, breaking some assumptions in the existing code.

This CL introduces a different implementation for the RefreshSoon method which ensures that the scheduled soon refresh cannot be overridden by subsequent refresh updates.

BUG= 644304 
TEST=unit test

Review-Url: https://codereview.chromium.org/2472593003
Cr-Commit-Position: refs/heads/master@{#429632}

[modify] https://crrev.com/6660a9d0880ad8cc3847fba07d98ef1f05d3869b/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc
[modify] https://crrev.com/6660a9d0880ad8cc3847fba07d98ef1f05d3869b/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h
[modify] https://crrev.com/6660a9d0880ad8cc3847fba07d98ef1f05d3869b/components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3086fa4adafab4af11281881dfbc5de3c601588b

commit 3086fa4adafab4af11281881dfbc5de3c601588b
Author: Maksim Ivanov <emaxx@google.com>
Date: Tue Nov 08 18:39:41 2016

Whitelist a new dir for Chrome sign-in screen extensions policy cache

The special directory will be added that will be used by Chrome for
storing the cache of the component policies for the extensions
installed in the sign-in profile.

This is needed for:
https://chromium-review.googlesource.com/#/c/406831/

BUG= chromium:644304 
TEST=manual

Change-Id: I0f78321edbb7056f0dd7282a813207d4771e2268
Reviewed-on: https://chromium-review.googlesource.com/408141
Commit-Ready: Maksim Ivanov <emaxx@chromium.org>
Tested-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/3086fa4adafab4af11281881dfbc5de3c601588b/client/site_tests/security_StatefulPermissions/security_StatefulPermissions.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/80c0d7bb07ce5064bbd0e5451b951be2023d050c

commit 80c0d7bb07ce5064bbd0e5451b951be2023d050c
Author: Maksim Ivanov <emaxx@google.com>
Date: Thu Nov 03 19:01:03 2016

login: Create dir for sign-in screen extensions policy cache in setup

A special directory is added that will be used by Chrome for storing the
cache of the component policies for the extensions installed in the
sign-in profile.

BUG= chromium:644304 
TEST=manual
CQ-DEPEND=CL:408141
Change-Id: I0900aa1977957d206eba2272559a805b1ec08608
Reviewed-on: https://chromium-review.googlesource.com/406831
Commit-Ready: Maksim Ivanov <emaxx@chromium.org>
Tested-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/80c0d7bb07ce5064bbd0e5451b951be2023d050c/login_manager/chrome_setup.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f

commit ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f
Author: emaxx <emaxx@chromium.org>
Date: Thu Nov 10 03:39:30 2016

Enable fetching of admin policies for login screen apps

This introduces fetching of admin policies for login screen apps. The
policy is fetched using a special policy domain, and is fetched as a
part of the device policy.

BUG= 644304 
TEST=new unit and browser tests

Review-Url: https://codereview.chromium.org/2441653003
Cr-Commit-Position: refs/heads/master@{#431168}

[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/extensions/api/storage/managed_value_store_cache.h
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/browser/policy/profile_policy_connector_factory.cc
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/profiles/signin_screen_managed_storage/Default/Extensions/baogpbmpccplckhhehfipokjaflkmbno/README
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/profiles/signin_screen_managed_storage/Default/Preferences
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/signin_screen_managed_storage/manifest.json
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/signin_screen_managed_storage/schema.json
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/signin_screen_managed_storage/test.html
[add] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chrome/test/data/extensions/signin_screen_managed_storage/test.js
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chromeos/chromeos_paths.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/chromeos/chromeos_paths.h
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/cloud/cloud_policy_manager.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/cloud/cloud_policy_manager.h
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/schema_registry.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/schema_registry.h
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/core/common/schema_registry_unittest.cc
[modify] https://crrev.com/ebe5cbc5306ce6938a0b79a68eaebefcd16a1c2f/components/policy/proto/device_management_backend.proto

Comment 8 by emaxx@chromium.org, Nov 10 2016

Components: Enterprise
Labels: -M-55 M-57
Status: Fixed (was: Started)

Comment 9 by emaxx@chromium.org, Nov 18 2016

Cc: antrim@chromium.org
Status: Started (was: Fixed)
As per  issue 666720 , these changes break the existing clients as DMServer started responding with errors to requests containing unknown policy types. So the new functionality will be temporarily disabled - and then I'll land a CL that hides the new policy fetch under the same command line flag that is planned to be used temporarily for changes in issue 576464.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f14a5fdb16cda4b707b127d1c8cf62115a72f709

commit f14a5fdb16cda4b707b127d1c8cf62115a72f709
Author: emaxx <emaxx@chromium.org>
Date: Fri Nov 18 14:21:32 2016

Disable fetching of policy for login screen apps

This disables fetching of policies for login screen apps, which used the
new policy type "google/chromeos/signinextension", as DMServer started
to respond with errors to requests with unknown policy types.

BUG= 666720 , 644304 
TEST=manual (run chromeos=1 build with an enrolled profile, navigate to chrome://policy, press "Reload policies", check that OK is displayed for the device policy)

Review-Url: https://codereview.chromium.org/2513903003
Cr-Commit-Position: refs/heads/master@{#433190}

[modify] https://crrev.com/f14a5fdb16cda4b707b127d1c8cf62115a72f709/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/f14a5fdb16cda4b707b127d1c8cf62115a72f709/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 18 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee89d810be7379fc0c713cf4f806efe5c38a548d

commit ee89d810be7379fc0c713cf4f806efe5c38a548d
Author: Maksim Ivanov <emaxx@chromium.org>
Date: Fri Nov 18 17:50:09 2016

Disable fetching of policy for login screen apps

This disables fetching of policies for login screen apps, which used the
new policy type "google/chromeos/signinextension", as DMServer started
to respond with errors to requests with unknown policy types.

BUG= 666720 , 644304 
TEST=manual (run chromeos=1 build with an enrolled profile, navigate to chrome://policy, press "Reload policies", check that OK is displayed for the device policy)

Review-Url: https://codereview.chromium.org/2513903003
Cr-Commit-Position: refs/heads/master@{#433190}
(cherry picked from commit f14a5fdb16cda4b707b127d1c8cf62115a72f709)

Review URL: https://codereview.chromium.org/2518613002 .

Cr-Commit-Position: refs/branch-heads/2924@{#3}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/ee89d810be7379fc0c713cf4f806efe5c38a548d/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/ee89d810be7379fc0c713cf4f806efe5c38a548d/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eb4901df37717dd05fd071a807a0ebaf563f0f3

commit 5eb4901df37717dd05fd071a807a0ebaf563f0f3
Author: emaxx <emaxx@chromium.org>
Date: Fri Dec 30 03:29:57 2016

Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG= 644304 , 666720 
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Review-Url: https://codereview.chromium.org/2603463003
Cr-Commit-Position: refs/heads/master@{#441015}

[modify] https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Comment 13 by emaxx@chromium.org, Dec 30 2016

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cce5ba611580090dbbd55686e0372a2a4955bbe

commit 3cce5ba611580090dbbd55686e0372a2a4955bbe
Author: tnagel <tnagel@chromium.org>
Date: Thu Jan 12 19:47:10 2017

Revert of Re-enable fetching component policies for login screen apps (patchset #3 id:40001 of https://codereview.chromium.org/2603463003/ )

Reason for revert:
I'm very sorry I have to revert this since it's breaking device policy updates.

https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7

Original issue's description:
> Re-enable fetching component policies for login screen apps
>
> This CL relands enabling fetching of policies for Chrome OS login screen
> apps.
>
> The originally landed code was temporarily disabled due to DMServer
> responding with errors when an unknown policy type was requested. Now
> this can be enabled back, after the DMServer got fixed to at least
> ignore the new policy type (until it starts to actually provide policies
> with this type).
>
> BUG= 644304 , 666720 
> TEST=re-enabled browser tests;
>      manual test: sign into an enrolled device, go to chrome://policy
>      and check that the device policies were fetched successfully
>
> Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
> Cr-Commit-Position: refs/heads/master@{#441015}

TBR=emaxx@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 644304 , 666720 

Review-Url: https://codereview.chromium.org/2621413007
Cr-Commit-Position: refs/heads/master@{#443328}

[modify] https://crrev.com/3cce5ba611580090dbbd55686e0372a2a4955bbe/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/3cce5ba611580090dbbd55686e0372a2a4955bbe/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/3cce5ba611580090dbbd55686e0372a2a4955bbe/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/3cce5ba611580090dbbd55686e0372a2a4955bbe/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Comment 15 by emaxx@chromium.org, Jan 17 2017

Status: Started (was: Fixed)
Looks like the DMServer is still not handling the fetches of the policies for the signin screen extensions correctly.

I've reported the problem to dkalin@. Once the server is fixed, this CL could be committed again.

Comment 16 by emaxx@chromium.org, Jan 30 2017

Labels: -M-57 M-58
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c4e6b642d971a31680fbb19858f56e1a4d8d7b

commit 94c4e6b642d971a31680fbb19858f56e1a4d8d7b
Author: emaxx <emaxx@chromium.org>
Date: Thu Feb 09 00:19:32 2017

Reland Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

TBR=tnagel@chromium.org

BUG= 644304 , 666720 
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Review-Url: https://codereview.chromium.org/2685893004
Cr-Commit-Position: refs/heads/master@{#449157}

[modify] https://crrev.com/94c4e6b642d971a31680fbb19858f56e1a4d8d7b/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/94c4e6b642d971a31680fbb19858f56e1a4d8d7b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/94c4e6b642d971a31680fbb19858f56e1a4d8d7b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/94c4e6b642d971a31680fbb19858f56e1a4d8d7b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Status: Fixed (was: Started)
Cc: achuith@chromium.org
Cc: trapti@chromium.org
Project Member

Comment 22 by bugdroid1@chromium.org, May 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a45c8831be6492b82adf6f719c9a8dd72d140693

commit a45c8831be6492b82adf6f719c9a8dd72d140693
Author: emaxx <emaxx@chromium.org>
Date: Sat May 06 19:00:16 2017

Remove useless statements from signin screen apps policy test

A couple of lines in the test setup code were actually unnecessary.

BUG= 644304 
TEST=existing tests
TBR=atwilson@

Review-Url: https://codereview.chromium.org/2863223002
Cr-Commit-Position: refs/heads/master@{#469859}

[modify] https://crrev.com/a45c8831be6492b82adf6f719c9a8dd72d140693/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc

Labels: -Type-Bug Type-Feature

Comment 24 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment