New issue
Advanced search Search tips

Issue 644303 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Crashing tests flakily timeout on Mac 10.9

Project Member Reported by wangxianzhu@chromium.org, Sep 6 2016

Issue description

Examples: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fsources%2Fdebugger%2Flive-edit-no-reveal.html%2C%20compositing%2Foverflow%2Fupdating-scrolling-container-and-content.html

- inspector/sources/debugger/live-edit-no-reveal.html (indirect proof): it occasionally crashes or timeouts on Mac other than 10.9, but but never reported crash on Mac 10.9.

- compositing/overflow/updating-scrolling-container-and-content.html (direct proof): It was reported 'TIMEOUT TIMEOUT TIMEOUT CRASH' or 'TIMEOUT' on Mac 10.9 while it crashed on other Mac versions.
 
Cc: -mgiuca@chromium.org mark@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
harness-tests/crash.html timeouts on Mac10.9:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=harness-tests%2Fcrash.html&testType=webkit_tests

The test showed the following stderr (https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/36622/layout-test-results/results.html):

[7987:1287:0906/140600:880080176459:FATAL:Internals.cpp(2632)] Check failed: false. Intentional crash
0   Content Shell Framework             0x0000000110d83323 _ZN4base5debug10StackTraceC1Ev + 19
1   Content Shell Framework             0x0000000110d98cb7 _ZN7logging10LogMessageD2Ev + 71
2   Content Shell Framework             0x0000000110ce6fce _ZN5blink9Internals5crashEv + 78
3   Content Shell Framework             0x000000010fe184e9 _ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE + 361
4   Content Shell Framework             0x000000010fe8d631 _ZN2v88internal12_GLOBAL__N_119HandleApiCallHelperILb0EEENS0_11MaybeHandleINS0_6ObjectEEEPNS0_7IsolateENS0_6HandleINS0_10HeapObjectEEESA_NS8_INS0_20FunctionTemplateInfoEEENS8_IS4_EENS0_16BuiltinArgumentsE + 993
5   Content Shell Framework             0x000000010fe8cb91 _ZN2v88internalL26Builtin_Impl_HandleApiCallENS0_16BuiltinArgumentsEPNS0_7IsolateE + 273
6   ???                                 0x00003430936063a7 0x0 + 57383235642279

It seems caused by the similar reason as  bug 619153 : the crash signal of child process is not handled by the browser process.
Status: WontFix (was: Assigned)
Found no acceptable solution. Just wait for the end of support of Mac 10.9.
Cc: thakis@chromium.org wangxianzhu@chromium.org
Owner: ----
Status: Available (was: WontFix)
Making this available.

https://codereview.chromium.org/2315403002/ was an unsuccessful trial. The patch works, but reviewers didn't like it.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d2582b92877456a786a0f3b483dc8080c322fdf

commit 1d2582b92877456a786a0f3b483dc8080c322fdf
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Mar 13 23:19:31 2017

Remove Timeout expectations on mac10.9 for crashes

 crbug.com/644303  seems to have been fixed. harness-tests/crash.html
no longer times out on mac10.9:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=harness-tests%2Fcrash.html

BUG= 644303 

Review-Url: https://codereview.chromium.org/2744243003
Cr-Commit-Position: refs/heads/master@{#456534}

[modify] https://crrev.com/1d2582b92877456a786a0f3b483dc8080c322fdf/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Available)

Sign in to add a comment