Android devices failure cause telemetry_perf_unittest to fail flakily |
||||
Issue descriptionLogs: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/135553 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/134827 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/134822 John, can you take a look?
,
Sep 7 2016
Looking.
,
Sep 7 2016
This may be an issue with a multipart solution: - There may be something that devil is doing that could be improved to handle these kinds of devices. I need to look more into that. - Telemetry could be more fault tolerant. At the moment, browser_finder.FindBrowser looks for all browsers on all devices in an attempt to find one that matches its options. On Android, that calls android_browser_finder.FindAllAvailableBrowsers for each device, which will fail w/ an exception if the device it's inspecting fails for some reason. This means that any fault on any device will bring down FindBrowser. I've uploaded https://codereview.chromium.org/2321663002/ as a possible fix.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64a891afd5061dc4d0623c2c03d33f92d81f4842 commit 64a891afd5061dc4d0623c2c03d33f92d81f4842 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Sep 08 01:56:05 2016 Roll src/third_party/catapult/ 576345e44..80c86caa5 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1 $ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s' 2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults. BUG= 644270 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2321813002 Cr-Commit-Position: refs/heads/master@{#417159} [modify] https://crrev.com/64a891afd5061dc4d0623c2c03d33f92d81f4842/DEPS
,
Sep 8 2016
AFAICT devil isn't doing anything wrong here; it doesn't hear anything from a device and times out. The CL above should make telemetry handle this case better.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64a891afd5061dc4d0623c2c03d33f92d81f4842 commit 64a891afd5061dc4d0623c2c03d33f92d81f4842 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Sep 08 01:56:05 2016 Roll src/third_party/catapult/ 576345e44..80c86caa5 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1 $ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s' 2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults. BUG= 644270 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2321813002 Cr-Commit-Position: refs/heads/master@{#417159} [modify] https://crrev.com/64a891afd5061dc4d0623c2c03d33f92d81f4842/DEPS |
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Sep 7 2016