Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 1 user
Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 637904



Sign in to add a comment
Android devices failure cause telemetry_perf_unittest to fail flakily
Project Member Reported by nedngu...@google.com, Sep 6 2016 Back to list
Project Member Comment 1 by sheriffbot@chromium.org, Sep 7 2016
Labels: Hotlist-Google
Status: Assigned
Looking.
This may be an issue with a multipart solution:
 - There may be something that devil is doing that could be improved to handle these kinds of devices. I need to look more into that.
 - Telemetry could be more fault tolerant. At the moment, browser_finder.FindBrowser looks for all browsers on all devices in an attempt to find one that matches its options. On Android, that calls android_browser_finder.FindAllAvailableBrowsers for each device, which will fail w/ an exception if the device it's inspecting fails for some reason. This means that any fault on any device will bring down FindBrowser. I've uploaded https://codereview.chromium.org/2321663002/ as a possible fix.
Project Member Comment 4 by bugdroid1@chromium.org, Sep 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a891afd5061dc4d0623c2c03d33f92d81f4842

commit 64a891afd5061dc4d0623c2c03d33f92d81f4842
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Sep 08 01:56:05 2016

Roll src/third_party/catapult/ 576345e44..80c86caa5 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1

$ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults.

BUG= 644270 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321813002
Cr-Commit-Position: refs/heads/master@{#417159}

[modify] https://crrev.com/64a891afd5061dc4d0623c2c03d33f92d81f4842/DEPS

Status: Fixed
AFAICT devil isn't doing anything wrong here; it doesn't hear anything from a device and times out.

The CL above should make telemetry handle this case better.
Project Member Comment 6 by bugdroid1@chromium.org, Sep 8 2016
Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a891afd5061dc4d0623c2c03d33f92d81f4842

commit 64a891afd5061dc4d0623c2c03d33f92d81f4842
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Sep 08 01:56:05 2016

Roll src/third_party/catapult/ 576345e44..80c86caa5 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1

$ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults.

BUG= 644270 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321813002
Cr-Commit-Position: refs/heads/master@{#417159}

[modify] https://crrev.com/64a891afd5061dc4d0623c2c03d33f92d81f4842/DEPS

Sign in to add a comment