New issue
Advanced search Search tips

Issue 644262 link

Starred by 2 users
Status: Fixed
Owner:
dtrainor@chromium.org
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug

Blocking:
issue 645202



Sign in to add a comment

Add an integration test for the Blimp rendering pipeline.

Project Member Reported by khushals...@chromium.org, Sep 6 2016 
We need an integration test that brings up the Blimp engine and client together, with a mocked out network pipe between them, loads a URL on the engine and validates the output produced on the client. I think doing this would be possible by making a copy request on the cc::Surface for the BlimpCompositor. Though we'll need to have the BrowserCompositor create a Display without a widget for the copy requests to be executed.

Comment 1 by dtrainor@chromium.org, Sep 8 2016

Blocking: 645202
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452f128c9232adc0c58caef4564f2fbf1b4bd9b0

commit 452f128c9232adc0c58caef4564f2fbf1b4bd9b0
Author: dtrainor <dtrainor@chromium.org>
Date: Wed Sep 14 19:11:40 2016

Add a full Blimp integration test.

- Add a full integration test that spawns both an engine and client in
  the same process and validates that the rendering pipeline produces
  the correct thing.
- Also add Linux support for BlimpContents and exposed a
  BlimpContentsView, which is required to gain access to the right
  classes to validate the rendering path.

Marking this as NOPRESUBMIT because there are some ScopedAllowIO calls during test setup and client tear down.  Please feel free to revert or ping me on any landing issues.

BUG= 644262 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2320923002
Cr-Commit-Position: refs/heads/master@{#418633}

[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/base/threading/thread_restrictions.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/app/compositor/browser_compositor.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/app/compositor/browser_compositor.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor_dependencies.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor_manager_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/blimp_contents_impl_android.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/blimp_contents_observer_proxy.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/blimp_view.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/blimp_view.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[delete] https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd/blimp/client/core/contents/blimp_contents_view.h
[delete] https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd/blimp/client/core/contents/blimp_contents_view_android.cc
[delete] https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd/blimp/client/core/contents/blimp_contents_view_android.h
[delete] https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd/blimp/client/core/contents/blimp_contents_view_aura.cc
[delete] https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd/blimp/client/core/contents/blimp_contents_view_aura.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl_android.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl_android.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl_aura.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_contents_view_impl_aura.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_navigation_controller_delegate.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/dummy_blimp_client_context.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/core/dummy_blimp_client_context.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContentsObserver.java
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/EmptyBlimpContentsObserver.java
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/contents/blimp_contents_observer.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/public/contents/blimp_contents_view.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/support/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/support/compositor/BUILD.gn
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/support/compositor/blimp_embedder_compositor.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/support/compositor/blimp_embedder_compositor.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/BUILD.gn
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/compositor/BUILD.gn
[rename] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/compositor/mock_compositor_dependencies.cc
[rename] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/compositor/mock_compositor_dependencies.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/compositor/test_blimp_embedder_compositor.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/client/test/compositor/test_blimp_embedder_compositor.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/BUILD.gn
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/blimp_browser_test.cc
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/blimp_browser_test.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/blimp_contents_view_readback_helper.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/blimp_contents_view_readback_helper.h
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/integration_test.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/waitable_content_pump.cc
[add] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/blimp/engine/browser_tests/waitable_content_pump.h
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/chrome/android/java/src/org/chromium/chrome/browser/tab/TabBlimpContentsObserver.java
[modify] https://crrev.com/452f128c9232adc0c58caef4564f2fbf1b4bd9b0/chrome/browser/android/tab_android.cc

Comment 3 by dtrainor@chromium.org, Sep 26 2016

Status: Fixed (was: Assigned)

Comment 4 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment