Issue metadata
Sign in to add a comment
|
Regression: Position of 'Allow/Block info bubble' is misplaced from 'View site info' icon.
Reported by
rk...@etouch.net,
Sep 6 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 55.0.2851.0 Revision 419dd0260fb2102873be9483c09a07be0510ab33-refs/heads/master@{#416559} OS: Windows(7,8,10),Linux What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site/ (2) Click on 'Location' and observe the position of 'Allow/Block info bubble'. Actual: Position of 'Allow/Block info bubble' is misplaced from 'View site info' icon. Expected: Position of 'Allow/Block info bubble' should be proper. This is a regression issue, broken in 'M-55', below is bisect info: Good Build: 55.0.2845.0 Bad Build: 55.0.2846.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/9c3c0a38de1c83ac9e6a9f683bad1291e12e2885..6a664cdc26940eb90d92f11eedce7be6e0baa09c?pretty=fuller&n=100 Suspecting: r415656 Note: Issue is not seen on Mac OS.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17cb9a2ce95bfaf85f4b209c45e87aa3da117326 commit 17cb9a2ce95bfaf85f4b209c45e87aa3da117326 Author: krb <krb@chromium.org> Date: Mon Sep 12 14:01:09 2016 [omnibox] Return reference to ImageView instead of LocationIconView Return a reference to the contained ImageView (the padlock) instead of the parent LocationIconView. The latter is quite wide when we fill in the label half of it, which we now do with site security level in some cases. The bubble (in the bug that is in the wrong place) anchors to the middle of whatever View you return to it, so we really want to give it the padlock here. BUG= 644222 Review-Url: https://codereview.chromium.org/2328983002 Cr-Commit-Position: refs/heads/master@{#417932} [modify] https://crrev.com/17cb9a2ce95bfaf85f4b209c45e87aa3da117326/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
,
Sep 13 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Sep 7 2016