New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644213 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug-Regression

Blocking:
issue 468240



Sign in to add a comment

Investigate object retainer infos for wrapper tracing

Project Member Reported by hlopko@chromium.org, Sep 6 2016

Issue description

http://crrev.com/2301213003 enables wrapper tracing for tests and disables 3 layout tests, which currently fail because there are no retainer infos collected during wrapper tracing.

In order to enable wrapper tracing on tot, we need to investigate whether retainer infos are needed, and if so, implement them for wrapper tracing.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b5bae67033e352f8ee94c550bc326cc87a7147

commit c5b5bae67033e352f8ee94c550bc326cc87a7147
Author: mlippautz <mlippautz@chromium.org>
Date: Tue Oct 04 14:41:58 2016

Create retainment infos from handles, even for tracing

For object tracing during heap profiling we still need to create retainment
infos to preserve current behavior.

BUG= chromium:468240 , chromium:644213 

Review-Url: https://codereview.chromium.org/2387373002
Cr-Commit-Position: refs/heads/master@{#422790}

[modify] https://crrev.com/c5b5bae67033e352f8ee94c550bc326cc87a7147/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Status: Fixed (was: Assigned)
Fixed for now. We should continue the discussion on dropping/rewriting the featurs of the heap profiler that are tied to object grouping.

Sign in to add a comment