New issue
Advanced search Search tips

Issue 644192 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.1%-5.6% regression in speedometer at 416116:416173

Project Member Reported by nikolaos@chromium.org, Sep 6 2016

Issue description

See the link to graphs below.
 
Cc: u...@chromium.org
Owner: u...@chromium.org

=== Auto-CCing suspected CL author ulan@chromium.org ===

Hi ulan@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [heap] Simplify heuristics for incremental step size. (patchset #5 id:180001 of https://codereview.chromium.org/2290333002/ )
Author  : ulan
Commit description:
  
Reason for revert:
Regressed GC times in v8.infinite_scroll_tbmv2 benchmarks.

Original issue's description:
> [heap] Simplify heuristics for incremental step size.
>
> This patch removes the code for speeding up marking.
>
> Now the step size depends on allocated bytes and
> invoked write barriers.
>
> We also ensure that the step size is large enough to
> justify the overhead of interrupting the generated code.
>
> BUG= chromium:616434 
> LOG=NO
>
> Committed: https://crrev.com/71a793e4b1026e69d4009df0a419fe260fe1a235
> Cr-Commit-Position: refs/heads/master@{#39067}

TBR=mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:616434 

Review-Url: https://codereview.chromium.org/2304613002
Cr-Commit-Position: refs/heads/master@{#39098}
Commit  : d09e026a9e5c5da7e6b7f2d4bc08f763cea36a18
Date    : Thu Sep 01 17:29:39 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@416138                9332.99  121.962  12  good
chromium@416142                9253.62  134.793  8   good
chromium@416144                9197.43  165.882  8   good
chromium@416144,v8@5f8a6ec4b1  9181.92  162.644  8   good
chromium@416144,v8@d09e026a9e  9517.34  173.363  8   bad    <--
chromium@416144,v8@903172e4fc  9636.59  223.248  8   bad
chromium@416145                9564.24  199.15   8   bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 644192

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: EmberJS-TodoMVC/EmberJS-TodoMVC
Relative Change: 1.85%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3290
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002282619267514848


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5275167922585600

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by u...@chromium.org, Sep 6 2016

Status: WontFix (was: Assigned)

Sign in to add a comment