New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644182 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in unibrow::Utf8::Validate

Project Member Reported by ClusterFuzz, Sep 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5826035432292352

Fuzzer: v8_wasm_asmjs_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x611000000da5
Crash State:
  unibrow::Utf8::Validate
  consume_string
  DecodeModule
  
Recommended Security Severity: Medium


Minimized Testcase (0.22 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94oS3XM94zL5syL_Eu3Wj9OZx7jMc6qc4MnXCb0Jkyo1tvo1m2lURPLqsPYjapJmJGRkuwv3F8oyX0YfNQBnGFt_JKhGbZxatINDa9Rf_250DcWqlggzTi1oFSB_vv0dW147l6NEcIIZRGP9hLhpIZIk27UMQ?testcase_id=5826035432292352

Issue manually filed by: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: mmoroz@chromium.org titzer@chromium.org kcc@chromium.org aizatsky@chromium.org
Components: Blink>JavaScript>WebAssembly
Labels: Pri-1
Owner: ahaas@chromium.org
Somewhat similar to  bug 642987 , but another reproducer and another fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1a5f8fa53665e7431124f6a9f4710d1bef8ae38b

commit 1a5f8fa53665e7431124f6a9f4710d1bef8ae38b
Author: ahaas <ahaas@chromium.org>
Date: Tue Sep 06 09:50:12 2016

[wasm] Validate the length of strings before validating the string.

BUG= chromium:644182 
R=titzer@chromium.org
TEST=module-decoder-unittest.cc:ExportNameWithInvalidStringLength

Review-Url: https://codereview.chromium.org/2310023002
Cr-Commit-Position: refs/heads/master@{#39199}

[modify] https://crrev.com/1a5f8fa53665e7431124f6a9f4710d1bef8ae38b/src/wasm/module-decoder.cc
[modify] https://crrev.com/1a5f8fa53665e7431124f6a9f4710d1bef8ae38b/test/unittests/wasm/module-decoder-unittest.cc

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6 2016

Labels: M-53
Project Member

Comment 5 by ClusterFuzz, Sep 8 2016

ClusterFuzz has detected this issue as fixed in range 416613:416621.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5826035432292352

Fuzzer: v8_wasm_asmjs_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x611000000da5
Crash State:
  unibrow::Utf8::Validate
  consume_string
  DecodeModule
  
Recommended Security Severity: Medium

Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=416613:416621

Minimized Testcase (0.22 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94oS3XM94zL5syL_Eu3Wj9OZx7jMc6qc4MnXCb0Jkyo1tvo1m2lURPLqsPYjapJmJGRkuwv3F8oyX0YfNQBnGFt_JKhGbZxatINDa9Rf_250DcWqlggzTi1oFSB_vv0dW147l6NEcIIZRGP9hLhpIZIk27UMQ?testcase_id=5826035432292352

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Sep 8 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 8 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 8 Deleted

Labels: -M-54
Labels: Release-0-M55
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 15 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 Deleted

Sign in to add a comment