New issue
Advanced search Search tips

Issue 644154 link

Starred by 1 user
Status: Verified
Owner:
yhanada@chromium.org
Closed: Sep 2016
Cc:
kathrelk...@chromium.org
nya@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox doesn't read ARC custom notifications.

Project Member Reported by yhanada@chromium.org, Sep 6 2016 
Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Show ARC notification from Android app
(2) Open the message center
(3) Go though notification list with ChromeVox

What is the expected output?
ChromeVox reads ARC custom notifications.

What do you see instead?
ChromeVox doesn't read ARC custom notifications.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e

commit 02f8ca650a8976e67ec89f0a9c87da70fc34ea2e
Author: yhanada <yhanada@chromium.org>
Date: Thu Sep 08 05:50:55 2016

arc: Make notifications from Android read by ChromeVox.

BUG= 644154 
TEST=Go through notification list in message center with ChromeVox,
     then ChromeVox read ARC custom notifications

Review-Url: https://codereview.chromium.org/2318463002
Cr-Commit-Position: refs/heads/master@{#417202}

[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/components/arc/common/notifications.mojom
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/arc/notification/arc_custom_notification_item.cc
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/notification.cc
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/notification.h
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/views/message_view.cc
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/views/message_view.h
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/02f8ca650a8976e67ec89f0a9c87da70fc34ea2e/ui/message_center/views/notification_view.h

Comment 3 by yhanada@chromium.org, Sep 12 2016

Status: Fixed (was: Started)

Comment 4 by yhanada@chromium.org, Sep 14 2016

Labels: Merge-Request-54
Status: Started (was: Fixed)

Comment 5 by dimu@chromium.org, Sep 14 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 6 by yhanada@chromium.org, Sep 14 2016

Cc: nya@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6

commit 1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6
Author: Shuhei Takahashi <nya@chromium.org>
Date: Wed Sep 14 05:10:19 2016

arc: Make notifications from Android read by ChromeVox.

BUG= 644154 
TEST=Go through notification list in message center with ChromeVox,
     then ChromeVox read ARC custom notifications

Review-Url: https://codereview.chromium.org/2318463002
Cr-Commit-Position: refs/heads/master@{#417202}
(cherry picked from commit 02f8ca650a8976e67ec89f0a9c87da70fc34ea2e)

Review URL: https://codereview.chromium.org/2338803004 .

Cr-Commit-Position: refs/branch-heads/2840@{#357}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/components/arc/common/notifications.mojom
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/arc/notification/arc_custom_notification_item.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/notification.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/notification.h
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/message_view.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/message_view.h
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/notification_view.h

Comment 8 by nya@chromium.org, Sep 14 2016 

Cherry-picked to M54 release branch on behalf of yhanada@.

Comment 9 by yhanada@chromium.org, Sep 14 2016

Status: Fixed (was: Started)
Thank you!

Comment 10 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 11 by dhadd...@chromium.org, Oct 18 2016

Cc: kathrelk...@chromium.org

Comment 12 by pbath...@chromium.org, Oct 25 2016

Status: Verified (was: Fixed)
verified on 54.0.2840.77
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6

commit 1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6
Author: Shuhei Takahashi <nya@chromium.org>
Date: Wed Sep 14 05:10:19 2016

arc: Make notifications from Android read by ChromeVox.

BUG= 644154 
TEST=Go through notification list in message center with ChromeVox,
     then ChromeVox read ARC custom notifications

Review-Url: https://codereview.chromium.org/2318463002
Cr-Commit-Position: refs/heads/master@{#417202}
(cherry picked from commit 02f8ca650a8976e67ec89f0a9c87da70fc34ea2e)

Review URL: https://codereview.chromium.org/2338803004 .

Cr-Commit-Position: refs/branch-heads/2840@{#357}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/components/arc/common/notifications.mojom
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/arc/notification/arc_custom_notification_item.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/notification.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/notification.h
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/message_view.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/message_view.h
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/1dd7e60768e5ef63ac6c327fcbf0a6b0be3aacc6/ui/message_center/views/notification_view.h
►

Sign in to add a comment