MacViews browser build fails gn check |
|||
Issue descriptionVersion: Since https://crrev.com/08fe0e95b421f4dec693af537a4ce139fb9cbe9f OS: macOS 10.11.6 What steps will reproduce the problem? (1) Run gn args out/{release folder name} and in the editor, add mac_views_browser=true. (2) Run gn check out/{release folder name}. What is the expected output? No errors. What do you see instead? A bunch of errors saying "Include not allowed". This can also be seen on the MacViews build bot - https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.10%20MacViews?numbuilds=200, which has been failing because of this. A bisect narrows it down to https://crrev.com/08fe0e95b421f4dec693af537a4ce139fb9cbe9f.
,
Sep 6 2016
One can add nogncheck annotations if you make sure the deps conditions match the preprocessor conditions. However, the bigger question is: are you sure you want to be compiling Aura? GN won't complain about header includes it doesn't know about, which is why it's OK for other platforms that don't use Aura. The fact that it's complaining about it means it's seeing the Aura targets in your build, which I'm not sure you want. If you don't use Aura, tracking down why that's getting referenced in your build and removing it is the correct solution for this case.
,
Sep 7 2016
,
Sep 9 2016
I believe we want to keep aura for for the first error, which refers to native_web_contents_modal_dialog_manager_views.cc - while USE_AURA is false on Mac, this file is used for other platforms which will need Aura. What I wasn't sure about were all the other gn check errors that appear as well (e.g. for browser_main_loop.cc, web_contents_view_guest.cc, etc), and wanted to get your advice on this before adding // nognchecks everywhere. For reference, I have an unpublished CL at https://codereview.chromium.org/2326933002/ for this.
,
Sep 26 2016
Looks like this was fixed in https://codereview.chromium.org/2360563002. |
|||
►
Sign in to add a comment |
|||
Comment 1 by patricia...@chromium.org
, Sep 6 2016