New issue
Advanced search Search tips

Issue 644116 link

Starred by 1 user
Status: Fixed
Owner:
arthurso...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 576261



Sign in to add a comment

PlzNavigate ctrl+click doesn't open a new tab.

Project Member Reported by arthurso...@chromium.org, Sep 5 2016 
Ctrl+click, middle click and all other related actions must open a new tab with PlzNavigate enabled.

Test that are currently failing:

* Layout tests:
   - editing/pasteboard/paste-when-over-link.html
   - fast/events/isolated-worlds-override-keystate.html
   - fast/events/main-world-does-not-override-keystate.html
   - fast/events/simulated-click-on-anchor-with-target-blank.html

* Browser tests:
   - ReferrerPolicyTest.MiddleClickOrigin
   - ReferrerPolicyTest.HttpsMiddleClickOrigin
   - ReferrerPolicyTest.MiddleClickRedirect
   - ReferrerPolicyTest.HttpsMiddleClickRedirect
   - ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin
   - ClickModifierTest.WindowOpenBasicClickTest
   - ClickModifierTest.WindowOpenControlShiftClickTest

Comment 1 by arthurso...@chromium.org, Sep 5 2016

Components: UI>Browser>Navigation
Owner: arthurso...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82b237354e75482b5857f11644877611896fa58

commit a82b237354e75482b5857f11644877611896fa58
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Thu Sep 15 21:46:48 2016

PlzNavigate: make ctrl+click works.

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG= 644116 

R=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2323153003
Cr-Commit-Position: refs/heads/master@{#418990}

[modify] https://crrev.com/a82b237354e75482b5857f11644877611896fa58/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a82b237354e75482b5857f11644877611896fa58/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
[modify] https://crrev.com/a82b237354e75482b5857f11644877611896fa58/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Comment 3 by arthurso...@chromium.org, Sep 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment