Issue metadata
Sign in to add a comment
|
1.2%-4.8% regression in top_10_mobile_memory_ignition at 415173:415356 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 5 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9002355223886268048
,
Sep 5 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9002355150442338464
,
Sep 6 2016
=== Auto-CCing suspected CL author jochen@chromium.org === Hi jochen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Create ScopeInfos while analyzing the Scope chain Author : jochen Commit description: Instead of creating them on demand all over the place. I plan to link ScopeInfos together, and having one place where all ScopeInfos are created will make this easier. R=verwaest@chromium.org,adamk@chromium.org TBR=mstarzinger@chromium.org BUG= v8:5215 Review-Url: https://codereview.chromium.org/2281073002 Cr-Commit-Position: refs/heads/master@{#39003} Commit : 0c3789fb6a55e5d900986f5172834ad666fcc072 Date : Tue Aug 30 09:48:56 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@415316 5741446 14174.8 5 good chromium@415323 5732489 7425.11 5 good chromium@415323,v8@88d603bb55 5732274 7190.89 5 good chromium@415323,v8@47bcea99fb 5735311 12121.9 5 good chromium@415323,v8@0c3789fb6a 6161434 77800.6 5 bad <-- chromium@415323,v8@9bdce030df 6161425 71199.1 5 bad chromium@415324 6174874 70722.2 5 bad chromium@415325 6111037 96861.9 5 bad chromium@415326 6183748 95289.1 5 bad chromium@415328 6211067 20436.5 5 bad chromium@415340 6139183 105324 5 bad Bisect job ran on: android_one_perf_bisect Bug ID: 644106 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory_ignition Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_max/http___m.youtube.com_results?q_science Relative Change: 6.93% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1596 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002355223886268048 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5652508112846848 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 6 2016
===== BISECT JOB RESULTS ===== Status: failed ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@415300 5083339 6069.36 5 good chromium@415322 5083445 6439.57 5 good chromium@415323 5080190 5671.61 5 good chromium@415323,v8@9bdce030df 5177640 4452.83 5 bad chromium@415324 5198754 20629.4 5 bad chromium@415325 5190958 2674.99 5 bad chromium@415328 5192066 6126.98 5 bad chromium@415333 5188986 4508.64 5 bad chromium@415343 5199946 19940.5 5 bad Bisect job ran on: android_nexus5X_perf_bisect Bug ID: 644106 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory_ignition Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_max/https___mobile.twitter.com_justinbieber?skip_interstitial_true Relative Change: 2.29% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/642 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002355150442338464 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5082629169217536 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/8003365259d7f2c11eeaa9b17935fb3ed7369bf9 commit 8003365259d7f2c11eeaa9b17935fb3ed7369bf9 Author: jochen <jochen@chromium.org> Date: Mon Sep 19 09:23:39 2016 Only create ScopeInfos for eagerly parsed scopes. If the scope was lazily parsed, the ScopeInfo won't be correct (and we won't store it in the SharedFunctionInfo). BUG= chromium:644106 R=marja@chromium.org Review-Url: https://codereview.chromium.org/2345243002 Cr-Commit-Position: refs/heads/master@{#39495} [modify] https://crrev.com/8003365259d7f2c11eeaa9b17935fb3ed7369bf9/src/ast/scopes.cc [modify] https://crrev.com/8003365259d7f2c11eeaa9b17935fb3ed7369bf9/src/ast/scopes.h [modify] https://crrev.com/8003365259d7f2c11eeaa9b17935fb3ed7369bf9/src/parsing/parser.cc
,
Oct 8 2016
Ross, those tests don't exist anymore... I'm pretty sure the regression is fixed, but I can't verify :(
,
Oct 10 2016
I guess that's now v8.browser but that has different pages :-/
,
Oct 24 2016
Yeah sorry we got rid of top_10_mobile_memory_ignition and replaced with v8.browsing, but that is indeed different pages. Let's mark as fixed.
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982652000894351232 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Sep 5 2016