New issue
Advanced search Search tips

Issue 644088 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo logs too many messages at -v 2

Project Member Reported by hta@chromium.org, Sep 5 2016

Issue description

In attempting to run the following command:

out/Default/content_shell --run-layout-test --enable-logging --v=3 third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/GUM-impossible-constraint.https.html

I discovered that this generated a *lot* of output - in fact 9 million lines of code before I got tired of wating.
Analyzing the logfile gave me the following top writers:

Linecount = 9540068
('node.cc(275)', 3836021)
('message_pipe_dispatcher.cc(144)', 1568003)
('node.cc(1081)', 1559741)
('message_pipe_dispatcher.cc(539)', 1297178)
('node.cc(431)', 1276921)
('video_track_adapter.cc(507)', 671)
('node.cc(539)', 252)

This makes it hard to run stuff that depends on seeing the output of DVLOG(3) statements.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080b6919d7c585a8d407255c8cb40efdc39eaf9e

commit 080b6919d7c585a8d407255c8cb40efdc39eaf9e
Author: hta <hta@chromium.org>
Date: Tue Sep 06 18:05:15 2016

Reduce the log level of frequently occuring DVLOGs

This changes the most verbose log statements in Mojo
from DVLOG(2) to DVLOG(4) (see bug for counts).
This should make DVLOG(3) statements useful again.

BUG= 644088 

Review-Url: https://codereview.chromium.org/2315483002
Cr-Commit-Position: refs/heads/master@{#416667}

[modify] https://crrev.com/080b6919d7c585a8d407255c8cb40efdc39eaf9e/mojo/edk/system/message_pipe_dispatcher.cc
[modify] https://crrev.com/080b6919d7c585a8d407255c8cb40efdc39eaf9e/mojo/edk/system/ports/node.cc

Comment 2 by hta@chromium.org, Sep 6 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment