Write-protected devices not recognized as read-only |
||||||
Issue descriptionChrome Version: 55.0.2851.0 Chrome OS Version: 8719.0.0 Steps To Reproduce: (1) Set policy: ExternalStorageReadOnly=false, ExternalStorageDisabled=false (2) Plug a read-only external storage (e.g. locked SD card) (3) Open Files app. (4) Right-click the drive on the left pane. Expected Result: The device is treated as read-only. "Format drive" option is grayed out. Actual Result: The device is treated as writable. "Format drive" option is active. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always
,
Sep 5 2016
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21448d5b5c6aaa880981393d0c55ef865b754596 commit 21448d5b5c6aaa880981393d0c55ef865b754596 Author: yamaguchi <yamaguchi@chromium.org> Date: Tue Sep 06 02:04:56 2016 Fix a bug where read-only volumes were recognized as read-write. This problem happened because the read-only attribute of the disk volume was unconditionally overwritten by the values in |access_modes_|. The patch fixes this problem by applying the values in |access_modes_| only when it's needed. The bug was introduced in crrev.com/2230713003 . BUG= 644077 Review-Url: https://codereview.chromium.org/2311863002 Cr-Commit-Position: refs/heads/master@{#416575} [modify] https://crrev.com/21448d5b5c6aaa880981393d0c55ef865b754596/chromeos/disks/disk_mount_manager.cc [modify] https://crrev.com/21448d5b5c6aaa880981393d0c55ef865b754596/chromeos/disks/disk_mount_manager_unittest.cc
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5535e06634f18c06db8d4928bbb4188b5e5b1d11 commit 5535e06634f18c06db8d4928bbb4188b5e5b1d11 Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 08 05:47:20 2016 Fix a bug where read-only volumes were recognized as read-write. This problem happened because the read-only attribute of the disk volume was unconditionally overwritten by the values in |access_modes_|. The patch fixes this problem by applying the values in |access_modes_| only when it's needed. The bug was introduced in crrev.com/2230713003 . BUG= 644077 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2311863002 Cr-Commit-Position: refs/heads/master@{#416575} (cherry picked from commit 21448d5b5c6aaa880981393d0c55ef865b754596) Review-Url: https://codereview.chromium.org/2316133002 Cr-Commit-Position: refs/branch-heads/2840@{#229} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5535e06634f18c06db8d4928bbb4188b5e5b1d11/chromeos/disks/disk_mount_manager.cc [modify] https://crrev.com/5535e06634f18c06db8d4928bbb4188b5e5b1d11/chromeos/disks/disk_mount_manager_unittest.cc
,
Sep 8 2016
,
Oct 3 2016
,
Oct 25 2016
Verified. M54-BETA-CHROMEOS-7 (8743.74.0, 54.0.2840.77) Device: Stout PVT Policy Server: DM server
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5535e06634f18c06db8d4928bbb4188b5e5b1d11 commit 5535e06634f18c06db8d4928bbb4188b5e5b1d11 Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 08 05:47:20 2016 Fix a bug where read-only volumes were recognized as read-write. This problem happened because the read-only attribute of the disk volume was unconditionally overwritten by the values in |access_modes_|. The patch fixes this problem by applying the values in |access_modes_| only when it's needed. The bug was introduced in crrev.com/2230713003 . BUG= 644077 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2311863002 Cr-Commit-Position: refs/heads/master@{#416575} (cherry picked from commit 21448d5b5c6aaa880981393d0c55ef865b754596) Review-Url: https://codereview.chromium.org/2316133002 Cr-Commit-Position: refs/branch-heads/2840@{#229} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5535e06634f18c06db8d4928bbb4188b5e5b1d11/chromeos/disks/disk_mount_manager.cc [modify] https://crrev.com/5535e06634f18c06db8d4928bbb4188b5e5b1d11/chromeos/disks/disk_mount_manager_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yamaguchi@chromium.org
, Sep 5 2016