New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644057 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

deqp/functional/gles3/shaderpackingfunction.html fails on Intel Mac

Project Member Reported by qiankun....@intel.com, Sep 5 2016

Issue description

The root cause is due to a negative operator bug on Intel Mac. Results of some (not all) expressions contain negative operator are wrong. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5b55edd8f9252a7f98ce3edae1ef1d55adae4415

commit 5b55edd8f9252a7f98ce3edae1ef1d55adae4415
Author: Qiankun Miao <qiankun.miao@intel.com>
Date: Mon Sep 05 06:55:15 2016

Work around unpackHalf2x16 emulation for Intel Mac

Negative operator is buggy in an expression on Intel Mac. Use abs(v) to
replace -v for negative value.

BUG= chromium:644057 
TEST=deqp/functional/gles3/shaderpackingfunction.html

Change-Id: I6182e7a00b162e36ed9278c0e5a2fdd8fb480959
Reviewed-on: https://chromium-review.googlesource.com/381152
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/5b55edd8f9252a7f98ce3edae1ef1d55adae4415/src/compiler/translator/BuiltInFunctionEmulatorGLSL.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb4e60b43e03ec97398628839dab490c41170d1

commit 9bb4e60b43e03ec97398628839dab490c41170d1
Author: jmadill <jmadill@chromium.org>
Date: Wed Sep 07 02:35:51 2016

Roll ANGLE a4e6f07..5a7e20e

https://chromium.googlesource.com/angle/angle.git/+log/a4e6f07..5a7e20e

BUG= chromium:643075 , chromium:642227 , chromium:638323 , chromium:644057 , 351528 , chromium:593024 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2312243003
Cr-Commit-Position: refs/heads/master@{#416828}

[modify] https://crrev.com/9bb4e60b43e03ec97398628839dab490c41170d1/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea43c322211a60280a17f5d0a4874ac0c49573e7

commit ea43c322211a60280a17f5d0a4874ac0c49573e7
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Wed Sep 07 06:07:57 2016

Update WebGL 2 conformance expectations

BUG= 644057 ,  593024 
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2312373003
Cr-Commit-Position: refs/heads/master@{#416858}

[modify] https://crrev.com/ea43c322211a60280a17f5d0a4874ac0c49573e7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 4 by zmo@chromium.org, Nov 5 2016

Status: Fixed (was: Assigned)

Sign in to add a comment