New issue
Advanced search Search tips

Issue 644043 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 643475



Sign in to add a comment

Notification prompts to format a disk even when the device is not writable

Project Member Reported by yamaguchi@chromium.org, Sep 5 2016

Issue description

Chrome OS Version: ToT

Steps To Reproduce:
(1) Delete all the partition in an SD card
(2) Slide the notch of the SD card to make it read-only
(3) Insert the SD card into a device
(4) See the "removable device detected" notification message on the right-bottom of the screen.

Expected Result:
The notification message tells the disk partitions were not recognized, and tell that it cannot be formatted as it's read-only.

Actual Result:
The notification message tells the disk partitions were not recognized, and shows a link to "format device".

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
If the user attempts to format the drive, the user will end up seeing an error. It does not give any clue why it fails.
Note that user can only attempt to format it only when opened the drive directly by the link provided by the notification. If user opens the drive by clicking in the list in Files app, it will correctly gray out the option to format it.

This is the origin issue of https://bugs.chromium.org/p/chromium/issues/detail?id=643475 .

 
Status: Started (was: Unconfirmed)
Summary: Notification prompts to format a disk even when the device is not writable (was: Notification prompts disk format even when the device is not formattable (read-only))
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d0c324611df6ceb900aae7766bc15517eb9bca

commit 01d0c324611df6ceb900aae7766bc15517eb9bca
Author: yamaguchi <yamaguchi@chromium.org>
Date: Thu Sep 08 05:44:44 2016

Hide "Format device" button in notification of unknown device when it is read only.

BUG= 644043 , 643475 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2310783004
Cr-Commit-Position: refs/heads/master@{#416576}
(cherry picked from commit 5c3efcf062d49a2585fc3be33286e91118cd7efc)

Review-Url: https://codereview.chromium.org/2319603002
Cr-Commit-Position: refs/branch-heads/2840@{#228}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d0c324611df6ceb900aae7766bc15517eb9bca

commit 01d0c324611df6ceb900aae7766bc15517eb9bca
Author: yamaguchi <yamaguchi@chromium.org>
Date: Thu Sep 08 05:44:44 2016

Hide "Format device" button in notification of unknown device when it is read only.

BUG= 644043 , 643475 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2310783004
Cr-Commit-Position: refs/heads/master@{#416576}
(cherry picked from commit 5c3efcf062d49a2585fc3be33286e91118cd7efc)

Review-Url: https://codereview.chromium.org/2319603002
Cr-Commit-Position: refs/branch-heads/2840@{#228}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Comment 8 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57
Status: Verified (was: Fixed)
Test version 9202.4.0, 57.0.2987.8

Sign in to add a comment