New issue
Advanced search Search tips

Issue 644042 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

SoM Staging: Revision ranges cover all failures, not just the first failing build

Project Member Reported by mgiuca@chromium.org, Sep 5 2016

Issue description

I have a failure on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) that started with this build:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36029 (containing 1 CL: r416467)
and is still ongoing as of:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36049 (containing 2 CLs: r416492 -- r416493)

Old SoM (https://sheriff-o-matic.appspot.com) shows the regression range as "416467 : 416467".
New SoM (https://sheriff-o-matic-staging.appspot.com) shows the regression range as "416472 - 416493".

It isn't helpful to report ALL the failures, since we can narrow it down to just the CLs in that first failing build. The old behaviour was correct.
 
Labels: Milestone-SoMNG
Owner: seanmccullough@chromium.org
Status: Available (was: Untriaged)
Status: Assigned (was: Available)
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7731726042f2668cc5af06f106a616620f11e9

commit 2a7731726042f2668cc5af06f106a616620f11e9
Author: eseckler <eseckler@chromium.org>
Date: Tue Sep 13 17:55:33 2016

Use updated interest rect when layer needs repainting.

This ensures that repaints don't use a larger rect than necessary, while also ensuring that a new interest rect that is contained within the previous interest rect doesn't cause a repaint on its own.

Currently, the previous interest rect is used if it didn't change too much even when the layer needs repainting, as introduced in https://codereview.chromium.org/1441973003. The original rationale behind this behavior was to ensure consistency between blink and cc. With cc refactorings, this should not be an issue any longer.

BUG= 646410 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2332273003
Cr-Commit-Position: refs/heads/master@{#418291}

[modify] https://crrev.com/2a7731726042f2668cc5af06f106a616620f11e9/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/2a7731726042f2668cc5af06f106a616620f11e9/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Comment 6 Deleted

No idea why bugdroid posted that CL to this issue. Looks totally unrelated. Shrug. 

Anyhoo this *should* have posted: https://chromium-review.googlesource.com/c/381578/
Status: Fixed (was: Started)

Sign in to add a comment