New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644036 link

Starred by 2 users
Status: Fixed
Owner:
cychiang@chromium.org
Closed: Sep 2016
Cc:
hychao@chromium.org
ka...@chromium.org
dgreid@chromium.org
█ chinyue@chromium.org
█ waihong@chromium.org
cychiang@chromium.org
chromeos-audio-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chameleon: support integration test for ARC++ audio playback

Project Member Reported by cychiang@chromium.org, Sep 5 2016 
Doc in goto/chameleon-audio-arc++
The recording were done in b/30005964.
Now I am going to implement for playback.

Comment 1 by cychiang@chromium.org, Sep 5 2016 

Posted these CLs in preparation for a server side test.

https://chromium-review.googlesource.com/381193 [autotest] arc_resource: Add resource for Play Music app
https://chromium-review.googlesource.com/381194 [autotest] multimedia: Control ARC audio playback in audio facade
https://chromium-review.googlesource.com/381195 [autotest] audio_widget_arc: Add CrosOutputWidgetARCHandler

https://chrome-internal-review.googlesource.com/284058 cheets_PlayMusicApp: Add a client side test for Play Music app
https://chrome-internal-review.googlesource.com/284156 Add autotest-{cheets, deps}-playmusic ebuild
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae85ddebe83470581f0427551415aaddfd961dd4

commit ae85ddebe83470581f0427551415aaddfd961dd4
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Mon Sep 05 10:18:51 2016

[autotest] arc_resource: Add resource for Play Music app

Add resource manager for Play Music app. It will handle audio file
playback through Play Music app.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: If5e0a61b54c986bfb29785437e5c7f1f513bee60
Reviewed-on: https://chromium-review.googlesource.com/381193
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/ae85ddebe83470581f0427551415aaddfd961dd4/client/cros/multimedia/arc_resource.py
[modify] https://crrev.com/ae85ddebe83470581f0427551415aaddfd961dd4/client/cros/multimedia/arc_resource_common.py
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae85ddebe83470581f0427551415aaddfd961dd4

commit ae85ddebe83470581f0427551415aaddfd961dd4
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Mon Sep 05 10:18:51 2016

[autotest] arc_resource: Add resource for Play Music app

Add resource manager for Play Music app. It will handle audio file
playback through Play Music app.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: If5e0a61b54c986bfb29785437e5c7f1f513bee60
Reviewed-on: https://chromium-review.googlesource.com/381193
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/ae85ddebe83470581f0427551415aaddfd961dd4/client/cros/multimedia/arc_resource.py
[modify] https://crrev.com/ae85ddebe83470581f0427551415aaddfd961dd4/client/cros/multimedia/arc_resource_common.py
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/86d8862fb75fe5261f42aa4e431151ba2c65b68f

commit 86d8862fb75fe5261f42aa4e431151ba2c65b68f
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Mon Sep 05 11:00:29 2016

[autotest] multimedia: Control ARC audio playback in audio facade

Expose functions so user can control audio playback through ARC.
Add a decorator function to check ARC resource in audio_facade_native.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: I77efed14adecca3f0c72d06ad549ce51cfa5fbb6
Reviewed-on: https://chromium-review.googlesource.com/381194
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/86d8862fb75fe5261f42aa4e431151ba2c65b68f/server/cros/multimedia/audio_facade_adapter.py
[modify] https://crrev.com/86d8862fb75fe5261f42aa4e431151ba2c65b68f/client/cros/multimedia/audio_facade_native.py
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c9dba03dba81100a46fa7919e9328b206d0ab08f

commit c9dba03dba81100a46fa7919e9328b206d0ab08f
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Mon Sep 05 11:28:24 2016

[autotest] audio_widget_arc: Add CrosOutputWidgetARCHandler

Add a handler to support playback through ARC.
It will be used if user set use_arc=True when creating widgets.

In CrosOutputWidgetARCHandler, handle format conversion from raw to wav,
which can be played by Play Music app in ARC.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: I8e4b09e0ca00f1edf59858fb7e100ad005c3fc47
Reviewed-on: https://chromium-review.googlesource.com/381195
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/c9dba03dba81100a46fa7919e9328b206d0ab08f/client/cros/chameleon/audio_widget_arc.py
[modify] https://crrev.com/c9dba03dba81100a46fa7919e9328b206d0ab08f/client/cros/chameleon/chameleon_audio_helper.py
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/547d61e358df3d1b198d2056f937c5824ae72574

commit 547d61e358df3d1b198d2056f937c5824ae72574
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Sep 06 16:45:03 2016

[autotest] sox_utils: Handle format conversion from raw to non-raw

Add an argument use_dst_header to convert_format to support format
conversion from raw to non-raw.
When converting to non-raw format, we should not pass '-t raw -e signed'
to sox.
The file format will be determined by the extension of destination path.

Let audio_test_data use this argument when the destination format is not
raw. This will be used to convert test data from raw file to wav file,
which can be played by Play Music app in ARC.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: I6198fe20b451f6c91a47beb8dd8d6619758a4f0e
Reviewed-on: https://chromium-review.googlesource.com/381535
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/547d61e358df3d1b198d2056f937c5824ae72574/client/cros/audio/audio_test_data.py
[modify] https://crrev.com/547d61e358df3d1b198d2056f937c5824ae72574/client/cros/audio/sox_utils.py
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e656fe721b6798130e29c3a009cfb2ed822bf28b

commit e656fe721b6798130e29c3a009cfb2ed822bf28b
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Sep 06 15:58:27 2016

[autotest] add audio_AudioARCPlayback test

Add the test to exercise audio playback function for ARC.
More control file other than headphone will be added.

BUG= chromium:644036 
TEST=run audio_AudioARCRecord.ext_mic test on samus to make sure
recording path still works.
TEST=run audio_AudioARCPlayback.headphone test on samus

Change-Id: I22d90a71682277675268ef9b7aa3af06549decc2
Reviewed-on: https://chromium-review.googlesource.com/381536
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[add] https://crrev.com/e656fe721b6798130e29c3a009cfb2ed822bf28b/server/site_tests/audio_AudioARCPlayback/audio_AudioARCPlayback.py
[add] https://crrev.com/e656fe721b6798130e29c3a009cfb2ed822bf28b/server/site_tests/audio_AudioARCPlayback/control.headphone
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/21cf23a3a5efa367da90602246cdb713584d9749

commit 21cf23a3a5efa367da90602246cdb713584d9749
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Sep 09 17:31:31 2016

[autotest] arc: Add grant_permissions utility function

This will be used in site tests to grant permissions to apps.

BUG= chromium:644036 
TEST=not used yet.

Change-Id: Ic56940da0f6d43cc9134fff384f9b063adbdcb2d
Reviewed-on: https://chromium-review.googlesource.com/383714
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Victor Hsieh <victorhsieh@chromium.org>

[modify] https://crrev.com/21cf23a3a5efa367da90602246cdb713584d9749/client/common_lib/cros/arc.py
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/a88c2b8d420a78c470e8d110426114f10d29fa00

commit a88c2b8d420a78c470e8d110426114f10d29fa00
Author: Cheng-Yi Chiang <cychiang@google.com>
Date: Mon Sep 05 11:08:39 2016
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/a88c2b8d420a78c470e8d110426114f10d29fa00

commit a88c2b8d420a78c470e8d110426114f10d29fa00
Author: Cheng-Yi Chiang <cychiang@google.com>
Date: Mon Sep 05 11:08:39 2016
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/a88c2b8d420a78c470e8d110426114f10d29fa00

commit a88c2b8d420a78c470e8d110426114f10d29fa00
Author: Cheng-Yi Chiang <cychiang@google.com>
Date: Mon Sep 05 11:08:39 2016
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/662994f298a473c0ec49ed4181ee47cef6aefea1

commit 662994f298a473c0ec49ed4181ee47cef6aefea1
Author: Cheng-Yi Chiang <cychiang@google.com>
Date: Mon Sep 05 04:20:38 2016
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/72f8250d584d77090e70121764195b1c7bad8ff9

commit 72f8250d584d77090e70121764195b1c7bad8ff9
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Sep 13 22:33:07 2016

autotest-server-tests: Add audio_AudioARCPlayback test

Add audio_AudioARCPlayback test.

BUG= chromium:644036 
TEST=None

Change-Id: Idd6b88ed65ac4beb2b39a0451a42a772d9196df8
Reviewed-on: https://chromium-review.googlesource.com/385178
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/72f8250d584d77090e70121764195b1c7bad8ff9/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild

Comment 14 by cychiang@chromium.org, Sep 28 2016

Status: Fixed (was: Started)
►

Sign in to add a comment