New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644034 link

Starred by 3 users
Status: Fixed
Owner:
sa...@chromium.org
Closed: Sep 2016
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

navigator.share should support url field

Project Member Reported by mgiuca@chromium.org, Sep 5 2016 
Version: 55
OS: Android

What steps will reproduce the problem?
(1) Call navigator.share({url: 'https://example.com'})
(2) Choose Google Keep.

What is the expected output?
The URL is displayed in the Keep note.

What do you see instead?
The Keep note is empty.

There's a TODO to implement this in Blink's NavigatorShare.cpp. This also requires changes to the Mojo interface and hookup in ShareServiceImpl.java on the Android side. (ShareHelper has a url parameter so it should just be a matter of passing it in there where we currently pass null.)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746afbd5808e9daa0333e66a7608e0d98283a9c8

commit 746afbd5808e9daa0333e66a7608e0d98283a9c8
Author: sammc <sammc@chromium.org>
Date: Fri Sep 09 00:35:25 2016

Use the URL passed to navigator.share().

BUG= 644034 

Review-Url: https://codereview.chromium.org/2309403002
Cr-Commit-Position: refs/heads/master@{#417452}

[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/chrome/android/BUILD.gn
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/share-arity.html
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/share-error.html
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/share-success.html
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/share-types.html
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/LayoutTests/webshare/share-without-user-gesture.html
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8/third_party/WebKit/public/platform/modules/webshare/webshare.mojom
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8

commit 67f97bf5345dc16b90a6418b4f3251b8ae0d49f8
Author: shans <shans@chromium.org>
Date: Fri Sep 09 00:48:25 2016

Revert of Use the URL passed to navigator.share(). (patchset #2 id:40001 of https://codereview.chromium.org/2309403002/ )

Reason for revert:
Causing compile failure on Blimp Linux (dbg)

Original issue's description:
> Use the URL passed to navigator.share().
>
> BUG= 644034 
>
> Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
> Cr-Commit-Position: refs/heads/master@{#417452}

TBR=esprehn@chromium.org,dcheng@chromium.org,dtrainor@chromium.org,mgiuca@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 644034 

Review-Url: https://codereview.chromium.org/2327713002
Cr-Commit-Position: refs/heads/master@{#417460}

[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/chrome/android/BUILD.gn
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/share-arity.html
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/share-error.html
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/share-success.html
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/share-types.html
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/LayoutTests/webshare/share-without-user-gesture.html
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/67f97bf5345dc16b90a6418b4f3251b8ae0d49f8/third_party/WebKit/public/platform/modules/webshare/webshare.mojom
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806

commit c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806
Author: sammc <sammc@chromium.org>
Date: Fri Sep 09 09:57:41 2016

Use the URL passed to navigator.share().

BUG= 644034 

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Review-Url: https://codereview.chromium.org/2309403002
Cr-Original-Commit-Position: refs/heads/master@{#417452}
Cr-Commit-Position: refs/heads/master@{#417546}

[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/chrome/android/BUILD.gn
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/share-arity.html
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/share-error.html
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/share-success.html
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/share-types.html
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/LayoutTests/webshare/share-without-user-gesture.html
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806/third_party/WebKit/public/platform/modules/webshare/webshare.mojom

Comment 5 by sa...@chromium.org, Sep 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment