Remove the --winhttp-proxy-resolver command line flag |
|||||||
Issue descriptionThis flag is in fact poorly named. Really it should be --use-system-proxy-resolver, as when set on Mac it uses the system resolver. Supporting this flag adds yet another mode which is undesirable. Moreover the WinHTTP proxy-resolver is incompatible with the regular Chrome resolver, in that it doesn't support things like file:// URLs or differentiating SOCKS versions, and it also has significant performance problems. Some care will need to be taken when deprecating/removing this, since it is entirely possible that some enterprises may be relying on it. (Due to other problems with how Chrome reads winhttp vs wininet proxy settings for various connections, --winhttp-proxy-resolver was the solution). Prior to removing support for winhttp proxy resolver we should tackle issue 644025 and make the regular resolver work in single-process mode. ⛆ |
|
|
,
Sep 5 2017
,
Sep 7 2017
Just for the record, I'm planning on leaving this intact for network servicification. I think removing this flag should be done independently of the servicification effort, so if it turns out we need to keep it, we can, rather than rushing out a fix for broken production code not intended to support the flag with the new logic flow. For sanity's sake, we're using the network service network setup code for in-process configuration as well as we convert things over, so we can't just break it in the new path.
,
Jun 13 2018
,
Jul 20
This is also causing pain and suffering over on issue 862121 . Turning this flag on breaks proxy.pac-based WebSocket proxying on both Windows and Mac. I'd be happy if it went away, but looking at the number of blocking bugs I should probably not count on it.
,
Jul 30
Probably the only real blocking bug is Issue 735637 , at which point I would go ahead and rename this to --deprecated-system-proxy-resolver for a release or two to see if there are any other weird dependencies. That is useful to see from Issue 862121 that it may be Forcepoint that is adding --winhttp-proxy-resolver! (this has been causing other problems like breaking the chrome proxy settings extension API, as --winhttp-proxy-resolver doesn't support other things like data: either)
,
Oct 2
|
||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Sep 5 2017Status: Untriaged (was: Available)