New issue
Advanced search Search tips

Issue 644022 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 624590



Sign in to add a comment

Move components/memory_coordinator to content/ and base/

Project Member Reported by bashi@chromium.org, Sep 5 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e70150fb5845bf645adec87036eca3b789d7ddcc

commit e70150fb5845bf645adec87036eca3b789d7ddcc
Author: bashi <bashi@chromium.org>
Date: Thu Sep 15 02:44:32 2016

Move memory_coordinator_client and its registry to base/memory

This is the first CL to move memory_coordinator outside components/.
Also, per discussion on [1], this CL removes MemoryCoordinatorClient
from HistoryBackend. We can re-add it if needed.

[1] https://codereview.chromium.org/2297243004/#msg14

BUG= 644022 

Review-Url: https://codereview.chromium.org/2311723002
Cr-Commit-Position: refs/heads/master@{#418766}

[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/base/BUILD.gn
[add] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/base/memory/memory_coordinator_client.h
[add] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/base/memory/memory_coordinator_client_registry.cc
[add] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/base/memory/memory_coordinator_client_registry.h
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/history/core/DEPS
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/history/core/browser/history_backend.h
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/browser/memory_coordinator.cc
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/browser/memory_coordinator.h
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/browser/memory_coordinator_unittest.cc
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/child/child_memory_coordinator_impl.cc
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/child/child_memory_coordinator_impl.h
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/common/BUILD.gn
[delete] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/components/memory_coordinator/common/client_registry.cc
[delete] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/components/memory_coordinator/common/client_registry.h
[delete] https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8/components/memory_coordinator/common/memory_coordinator_client.h
[modify] https://crrev.com/e70150fb5845bf645adec87036eca3b789d7ddcc/components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a626404dc444c17bd3722bc111857ab288e4a0f3

commit a626404dc444c17bd3722bc111857ab288e4a0f3
Author: bashi <bashi@chromium.org>
Date: Thu Sep 15 04:49:51 2016

Move components/memory_coordinator -> content/

Basically,
- components/memory_coordinator/public/interfaces -> content/common
- components/memory_coordinator/common -> content/common
- components/memory_coordinator/browser -> content/browser
- components/memory_coordinator/child -> content/child

BUG= 644022 

Review-Url: https://codereview.chromium.org/2321313002
Cr-Commit-Position: refs/heads/master@{#418783}

[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/components/BUILD.gn
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/components/OWNERS
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/DEPS
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/browser/BUILD.gn
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/browser/memory_monitor.cc
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/browser/memory_monitor_linux.h
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/child/BUILD.gn
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/child/child_memory_coordinator_impl_android.h
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/common/BUILD.gn
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/common/memory_coordinator_export.h
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/common/memory_coordinator_features.cc
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/common/memory_coordinator_features.h
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/public/interfaces/BUILD.gn
[delete] https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09/components/memory_coordinator/public/interfaces/OWNERS
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/BUILD.gn
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/DEPS
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/OWNERS
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_coordinator.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_coordinator.h
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_coordinator_browsertest.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_coordinator_unittest.cc
[add] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor.h
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_linux.cc
[add] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_linux.h
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_linux_unittest.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_win.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_win.h
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/memory_monitor_win_unittest.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/test_memory_monitor.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/memory/test_memory_monitor.h
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/BUILD.gn
[copy] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/OWNERS
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/child_memory_coordinator_impl.cc
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/child_memory_coordinator_impl.h
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/child_memory_coordinator_impl_android.cc
[add] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/child_memory_coordinator_impl_android.h
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/child/memory/child_memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/common/BUILD.gn
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/common/child_memory_coordinator.mojom
[rename] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/common/memory_coordinator.mojom
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/public/common/content_features.cc
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/public/common/content_features.h
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/renderer/BUILD.gn
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/renderer/DEPS
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/renderer/render_thread_impl.h
[modify] https://crrev.com/a626404dc444c17bd3722bc111857ab288e4a0f3/content/test/BUILD.gn

Comment 3 by bashi@chromium.org, Sep 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment