Source shouldn't have a media query listener after media attr is removed |
||||
Issue descriptionVersion: 54 OS: All As caught during code review by cbiesinger@[1], we need to remove listeners in case media is empty. [1] https://codereview.chromium.org/2256533002/#msg22
,
Sep 5 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/626cb8e7078d2d0bc98be866c664e201c3434ad2 commit 626cb8e7078d2d0bc98be866c664e201c3434ad2 Author: yoav <yoav@yoav.ws> Date: Thu Sep 08 02:58:00 2016 Remove HTMLSourceElement media listener if media attribute is empty This CL removes the MediaQueryListener from HTMLSourceElement that their media attribute was removed. BUG= 643972 Review-Url: https://codereview.chromium.org/2307353002 Cr-Commit-Position: refs/heads/master@{#417176} [modify] https://crrev.com/626cb8e7078d2d0bc98be866c664e201c3434ad2/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
,
Sep 8 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/626cb8e7078d2d0bc98be866c664e201c3434ad2 commit 626cb8e7078d2d0bc98be866c664e201c3434ad2 Author: yoav <yoav@yoav.ws> Date: Thu Sep 08 02:58:00 2016 Remove HTMLSourceElement media listener if media attribute is empty This CL removes the MediaQueryListener from HTMLSourceElement that their media attribute was removed. BUG= 643972 Review-Url: https://codereview.chromium.org/2307353002 Cr-Commit-Position: refs/heads/master@{#417176} [modify] https://crrev.com/626cb8e7078d2d0bc98be866c664e201c3434ad2/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp |
||||
►
Sign in to add a comment |
||||
Comment 1 by y...@yoav.ws
, Sep 4 2016