New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643945 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
Security-UX-Consistency


Sign in to add a comment

[MD] Verbose state chip: The new Animation appears, when you switch between NewTabPage when something is typed in the Omnibox and a Secure page

Project Member Reported by meh...@chromium.org, Sep 3 2016

Issue description

Version: Chrome 55.0.2848.0 canary (64-bit)
OS: OSX 10.11.6
MacBook Air 11" - NonRetina

What steps will reproduce the problem?
(1) Open a secure page
(2) Open a NewTabPage
(3) Type something into the Omnibox in the NewTabPage
(4) Switch between both tabs

What is the expected output?
No Animation, like when you switch between a secure page and a normal page.

What do you see instead?
The Animation appears on the secure page, when you switch between both tabs. 

Please use labels and text to provide additional information.
A screencast is attached. If you need more information, please let me know.

Thanks and regards
Mehmet
 
 
chip.mov
1.2 MB Download
Components: Security>UX
Labels: Hotlist-SecurityIndicators Hotlist-Security-UX-Consistency
Components: UI>Browser>Omnibox>SecurityIndicators
Components: -Security>UX
Labels: -Hotlist-SecurityIndicators

Comment 4 by raymes@chromium.org, Nov 30 2016

Components: UI>Browser>Permissions>Indicators
This also happens when switching between a HTTP page (icon only) and a page with security chip.
Toolbar.gif
247 KB View Download

Comment 6 by shrike@chromium.org, Jan 17 2017

Labels: -Pri-2 ReleaseBlock-Stable M-56 Pri-1
Cc: spqc...@chromium.org emilyschechter@chromium.org maxwalker@chromium.org jdonnelly@chromium.org
 Issue 681703  has been merged into this issue.
Labels: -M-56 M-57
Moving to M57.  We're cutting the first stable candidate in four days, and this doesn't seem like it's high enough priority to block the launch / do an emergency fix.
Labels: Needs-triage-Mobile
Labels: -M-57 M-56
I don't agree with c#8 - it looks pretty sloppy and makes it seem like we don't know what we're doing. We should at least understand what's involved in fixing this bug.

Re: c#9, this is a Mac-only bug as far as I know.

Status: Started (was: Assigned)
CL in review:  https://codereview.chromium.org/2650843002/
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6771b80c488c2c1b685ab2f674928ee09654ab15

commit 6771b80c488c2c1b685ab2f674928ee09654ab15
Author: spqchan <spqchan@chromium.org>
Date: Tue Jan 24 17:22:54 2017

[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user edits  the
omnibox or switch tabs

BUG= 643945 

Review-Url: https://codereview.chromium.org/2650843002
Cr-Commit-Position: refs/heads/master@{#445749}

[modify] https://crrev.com/6771b80c488c2c1b685ab2f674928ee09654ab15/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Labels: Merge-Request-56
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Only 6 days from stable, we might already have a stable candidate build
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-56 -ReleaseBlock-Stable -Merge-Review-56 -Needs-triage-Mobile M-57
After sleeping on it, while I do want this bug fixed I am nervous about making a change to what will be M56 stable in under a week (and little air time on the change). This regression also apparently lives in M55 already.
Labels: -Hotlist-Merge-Review
Status: Fixed (was: Started)
I already fixed this at some point
Okay thanks. I see the animation only when I visit an insecure site with the "Not Secure" label. Is this behavior correct?
Yes, only "Not Secure" should animate. 

Sign in to add a comment