Issue metadata
Sign in to add a comment
|
MD User Account Button: Regression - Hover button is not aligned with the Settings Button |
||||||||||||||||||||||
Issue descriptionVersion: Chrome 55.0.2848.0 canary (64-bit) OS: OSX 10.11.6 MacBook Air 11" - NonRetina What steps will reproduce the problem? (1) Take a look at the position of the new MD User Account button and compare it with the position of the Settings Button. What is the expected output? The new MD User Account button should be nicely aligned with the Settings Button. What do you see instead? They are not aligned. Please use labels and text to provide additional information. This is a regression after https://codereview.chromium.org/2286993002. Screenshots are attached. Thanks for fixing it in advance. Mehmet
,
May 8 2017
,
Oct 20 2017
,
Oct 23 2017
It looks like shifting 1px or 2px won't be sufficient to fix it. It'll still be 0.5pts off. I can try to apply some transformation to it, but it *might* end up like crisp looking. What are your thoughts, shrike@?
,
Oct 24 2017
Hi, a question: is the profile button in the first screenshot already shifted by 1px? The first screenshot is looking already fine/better to me than the second screenshot (even though it is off in both cases).
,
Oct 24 2017
Yes sorry, the first one is shifted by 1 px. The second is 2px They're still off by 0.5px but a bit better than before
,
Oct 24 2017
The first screenshot looks pretty good. I'm content to leave it there.
,
Oct 24 2017
Great! Thanks all, I'll submit the CL for review then
,
Oct 24 2017
Thank you for the clarification. As already mentioned I like the first screencast (shifted only by 1px), because on non-retina it would also look much better than shifted by 2px. Let‘s wait what shrike@ says :-) Thank you.
,
Oct 24 2017
Upps, sorry, my comment was too late. Great, thank you for using only 1px.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82 commit 2ac5993dfb95886b017cacfd0d3c89c12b3f3b82 Author: spqchan <spqchan@chromium.org> Date: Wed Oct 25 21:35:16 2017 [Mac] Shift the Generic Avatar Button by 1pt Unit test: BrowserWindowLayoutTest.TestAvatarButtonAlignment Bug: 643942 Change-Id: Ic5383e4b0564627cf0f7de26f58611eeff241302 Reviewed-on: https://chromium-review.googlesource.com/735981 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#511596} [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/2ac5993dfb95886b017cacfd0d3c89c12b3f3b82/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Oct 26 2017
Great, thanks for verifying! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Sep 3 2016