New issue
Advanced search Search tips

Issue 643937 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Fix style warnings in blinkpy codebase.

Project Member Reported by qyears...@chromium.org, Sep 3 2016 
After  issue 598897 , stricter pylint checks are now enabled for new code in webkitpy, although existing code doesn't necessarily conform to new the checks. I made several changes in the past to start:

  r392119
  r392265
  r393077
  r397453
  r397636
  r400487
  r408745
  r410728

This issue could be considered "fixed" when lint-webkitpy comes up with no warnings for the whole codebase. Current issues can be listed by running the following command from the webkitpy directory:
  pylint --rcfile=pylintrc $(find . -name "*.py" | grep -v thirdparty)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7beb14b269407802ce44aad29b778529ee473ed

commit c7beb14b269407802ce44aad29b778529ee473ed
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Sep 06 16:20:14 2016

webkitpy: Make all regex strings use raw string literals.

This fixes the anomalous-backslash-in-string pylint warnings.

The advantage of using raw string literals is that it makes the behavior
of backslashes a little easier to understand; with normal string literals,
"\a\b\c" is "<BEL><BS><backslash><lower-case-c>", whereas with raw
string literals, each of those backslashes is just a backslash character.

The advantage of this pylint warning in general is that enforces
escaping literal backslashes in regular strings, which makes it
clear that a backslash was intended rather than an escape sequence.

BUG=643937

Review-Url: https://codereview.chromium.org/2305143003
Cr-Commit-Position: refs/heads/master@{#416636}

[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader.py
[modify] https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721212bf1af3f3bed906f8aa86ee1980c3f5c6af

commit 721212bf1af3f3bed906f8aa86ee1980c3f5c6af
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Sep 12 20:12:21 2016

Run format-webkitpy and fix long lines.

Specifically: I ran format-webkitpy --leave-strings-alone on the codebase,
and discovered that autopep8 doesn't automatically break long lines in
some circumstances. (yapf breaks up more long lines, but I think it's
too aggressive, and reformats things in ways that I don't like sometimes.)

BUG=643937

Review-Url: https://codereview.chromium.org/2329263002
Cr-Commit-Position: refs/heads/master@{#418022}

[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json_test.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_input.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commit_announcer.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py
[modify] https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8cbec24369a869717603e32d9d4ffd4fbc64264

commit e8cbec24369a869717603e32d9d4ffd4fbc64264
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Sep 27 19:56:47 2016

Clean up most style warnings in webkitpy/style/checker_unittest.py.

BUG=643937

Review-Url: https://codereview.chromium.org/2373063002
Cr-Commit-Position: refs/heads/master@{#421308}

[modify] https://crrev.com/e8cbec24369a869717603e32d9d4ffd4fbc64264/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9b72ea61eece7cd926669c5ee808af843cfc0d

commit fc9b72ea61eece7cd926669c5ee808af843cfc0d
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Oct 05 21:59:13 2016

Don't access Port._filesystem directly (use Port.host.filesystem instead).

In some places, port.host.filesystem is used while in others
port._filesystem is used. Since the Port object's copy of
the FileSystem object is set based on its Host object, these
are the same.

The purpose of this CL is to make the codebase more consistent,
and it makes it so that Port._filesystem is just a private shortcut
attribute, and is not depended upon.

BUG=643937

Review-Url: https://codereview.chromium.org/2399613002
Cr-Commit-Position: refs/heads/master@{#423308}

[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9b72ea61eece7cd926669c5ee808af843cfc0d

commit fc9b72ea61eece7cd926669c5ee808af843cfc0d
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Oct 05 21:59:13 2016

Don't access Port._filesystem directly (use Port.host.filesystem instead).

In some places, port.host.filesystem is used while in others
port._filesystem is used. Since the Port object's copy of
the FileSystem object is set based on its Host object, these
are the same.

The purpose of this CL is to make the codebase more consistent,
and it makes it so that Port._filesystem is just a private shortcut
attribute, and is not depended upon.

BUG=643937

Review-Url: https://codereview.chromium.org/2399613002
Cr-Commit-Position: refs/heads/master@{#423308}

[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
[modify] https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6180682439e536c07e8b4a69d9347aac6698929f

commit 6180682439e536c07e8b4a69d9347aac6698929f
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 16 00:33:34 2016

Clean up pylint warnings in filesystem_mock.py.

Warnings fixed:
 - 1 unused import
 - some variable names very short
 - some variable/argument names conflict with builtins

BUG=643937

Review-Url: https://codereview.chromium.org/2497153002
Cr-Commit-Position: refs/heads/master@{#432317}

[modify] https://crrev.com/6180682439e536c07e8b4a69d9347aac6698929f/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b7287623169fc5e9fefa6e310c2c6a3ef35ad0

commit 91b7287623169fc5e9fefa6e310c2c6a3ef35ad0
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 16 00:34:19 2016

Fix expression-not-assigned pylint warnings in webkitpy.

This removes unnecessary commas from a couple of lines;
it should have no effect on behavior.

BUG=643937

Review-Url: https://codereview.chromium.org/2499873002
Cr-Commit-Position: refs/heads/master@{#432318}

[modify] https://crrev.com/91b7287623169fc5e9fefa6e310c2c6a3ef35ad0/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py
[modify] https://crrev.com/91b7287623169fc5e9fefa6e310c2c6a3ef35ad0/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d80242b605bbf316d9908bc5fbe485ffeb51a748

commit d80242b605bbf316d9908bc5fbe485ffeb51a748
Author: qyearsley <qyearsley@chromium.org>
Date: Sat Nov 19 03:36:37 2016

Remove unused imports in webkitpy.

It seems like I did this before, but there were apparently still
a bunch of unused imports.

This CL also sorts imports in files where unused imports are removed.

I checked that this shouldn't remove any imports of webkitpy.common.version_check.

BUG=643937

Review-Url: https://codereview.chromium.org/2469153002
Cr-Commit-Position: refs/heads/master@{#433392}

[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/style/main_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
[modify] https://crrev.com/d80242b605bbf316d9908bc5fbe485ffeb51a748/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5188bb7143c43f16b2393ba174ef9d1af2e442bc

commit 5188bb7143c43f16b2393ba174ef9d1af2e442bc
Author: qyearsley <qyearsley@chromium.org>
Date: Sun Nov 20 00:02:42 2016

Clean up style in layout_tests/models/test_expectations.py.

This includes cleaning up code layout, spelling in strings, and variable names, and running format-webkitpy in this file and its related unit test. This shouldn't affect behavior; all tests still pass.

BUG=643937

Review-Url: https://codereview.chromium.org/2512203002
Cr-Commit-Position: refs/heads/master@{#433436}

[modify] https://crrev.com/5188bb7143c43f16b2393ba174ef9d1af2e442bc/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/5188bb7143c43f16b2393ba174ef9d1af2e442bc/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a975e6c1a54bdd9304df38b85fdd9669f478a4

commit 73a975e6c1a54bdd9304df38b85fdd9669f478a4
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Dec 14 23:10:30 2016

In "pylint: disable=" comments in webkitpy, use symbolic names.

Reason: Using symbolic names helps to make it clear what is disabled.

BUG=643937

Review-Url: https://codereview.chromium.org/2569153003
Cr-Commit-Position: refs/heads/master@{#438664}

[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/common/multiprocessing_bootstrap.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py
[modify] https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8

commit 7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Dec 23 00:00:18 2016

Style change: Rename error variables "e" -> "error"

Reason: Pylint warns about single-character variable names (outside of list comprehension expressions etc) for a couple of reasons; they are sometimes not clear or descriptive, and they may be harder to search/replace.

While it may make sense to make an exception for `e` as an error name in except clauses, it's more consistent to make it a general rule that variable names should be more than one character.

This CL also removes redundant conversions to str when formatting, e.g.
  '<%s>' % str(e)  ==>  '<%s>' % e

BUG=643937

Review-Url: https://codereview.chromium.org/2580293002
Cr-Commit-Position: refs/heads/master@{#440548}

[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized_unittest.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/formatter/main_unittest.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/7dab4a5d9e36d0041c5f4f5101c2816b0b16fee8/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f

commit e50b0019b1a4fa5d47499b5733d9402b14ff8e6f
Author: qyearsley <qyearsley@chromium.org>
Date: Sat Dec 31 20:33:38 2016

Rename convert_404_to_None -> return_none_on_404.

Reason: Pylint gives a warning about the current name because variable
and method names generally don't have capitals in them. Also, I think
the new name is slightly clearer.

BUG=643937

Review-Url: https://codereview.chromium.org/2606103002
Cr-Commit-Position: refs/heads/master@{#441043}

[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py
[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py
[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py
[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py
[modify] https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ebda3c1ca63e74c71648c6547e4575d3bbae503

commit 5ebda3c1ca63e74c71648c6547e4575d3bbae503
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 18 19:43:24 2017

Fix pylint warnings in test_importer.py.

This is a simple CL that updates a couple variable names in test_importer.py to conform to the general convention that local variables are lowercase and more than 2 letters.

BUG=643937

Review-Url: https://codereview.chromium.org/2632083003
Cr-Commit-Position: refs/heads/master@{#444440}

[modify] https://crrev.com/5ebda3c1ca63e74c71648c6547e4575d3bbae503/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d58fd482467df826e6c4173d91c3a71561d1d00

commit 4d58fd482467df826e6c4173d91c3a71561d1d00
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Feb 09 16:48:56 2017

Fix all "dangerous-default-value" pylint warnings.

BUG=643937

Review-Url: https://codereview.chromium.org/2679393004
Cr-Commit-Position: refs/heads/master@{#449318}

[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser_unittest.py
[modify] https://crrev.com/4d58fd482467df826e6c4173d91c3a71561d1d00/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc15ef0491997795eee00a1595727b26628990c7

commit fc15ef0491997795eee00a1595727b26628990c7
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 22 23:22:28 2017

Change all relative imports in webkitpy to absolute imports.

BUG=643937

Review-Url: https://codereview.chromium.org/2715553002
Cr-Commit-Position: refs/heads/master@{#452265}

[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/common_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/text.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/text_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xcodeproj_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xml_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/filter_unittest.py
[modify] https://crrev.com/fc15ef0491997795eee00a1595727b26628990c7/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa73ea0f5ac4aadf0f30e12a3e86fa3388ec1be

commit aaa73ea0f5ac4aadf0f30e12a3e86fa3388ec1be
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Feb 23 00:53:37 2017

Fix up pylint warnings in run_webkit_tests_unittest.py.

In this CL:
 - remove unused arg in helper function
 - rename methods to conform to naming convention
 - add pylint disable to not warn about testing protected methods

BUG=643937

Review-Url: https://codereview.chromium.org/2715573002
Cr-Commit-Position: refs/heads/master@{#452317}

[modify] https://crrev.com/aaa73ea0f5ac4aadf0f30e12a3e86fa3388ec1be/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Comment 21 by qyears...@chromium.org, Mar 4 2017

Status: Started (was: Assigned)

Comment 22 by qyears...@chromium.org, Mar 19 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 23 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2dcc699777d349adcb8a97ac069279977f14f2f

commit e2dcc699777d349adcb8a97ac069279977f14f2f
Author: Quinten Yearsley <qyearsley@google.com>
Date: Sat May 27 01:25:51 2017

Fix style warnings in layout_tests/controllers/manager.py.

Bug: 643937
Change-Id: I1c70a77637e52550a8bdb8786c3abce6f6517b3d
Reviewed-on: https://chromium-review.googlesource.com/516425
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475197}
[modify] https://crrev.com/e2dcc699777d349adcb8a97ac069279977f14f2f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Comment 24 by qyears...@chromium.org, Jun 26 2017

Cc: qyears...@chromium.org
Owner: ----
Status: Available (was: Started)
[Not marking as owned by me, because style clean-ups can be done by anyone. The main purpose of this CL is to serve as an bug to associate with clean-up CLs.]
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38bc9db968e2187df4af71ab4052f6a909faff84

commit 38bc9db968e2187df4af71ab4052f6a909faff84
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Jul 11 01:17:22 2017

Style: Don't use builtin name as arg name in User

This CL changes an argument name from raw_input, which conflicts a
builtin name. This is a minor clean-up CL.

Bug: 643937
Change-Id: I88821d6537f9d24b3f78de9b21e0ff690f9c3491
Reviewed-on: https://chromium-review.googlesource.com/564699
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485481}
[modify] https://crrev.com/38bc9db968e2187df4af71ab4052f6a909faff84/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/38bc9db968e2187df4af71ab4052f6a909faff84/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28ad49bb0bbcc405d8781e537f9944b527840fd

commit b28ad49bb0bbcc405d8781e537f9944b527840fd
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Jul 17 20:37:47 2017

webkitpy cleanup: Remove unused arg from Printer.print_results.

Bug: 643937
Change-Id: I884264b415d2eb0e4a08cde6f2ed0f314ed72e4b
Reviewed-on: https://chromium-review.googlesource.com/574657
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487229}
[modify] https://crrev.com/b28ad49bb0bbcc405d8781e537f9944b527840fd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/b28ad49bb0bbcc405d8781e537f9944b527840fd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

Comment 27 by tkent@chromium.org, May 9 2018

Summary: Fix style warnings in blinkpy codebase. (was: Fix style warnings in webkitpy codebase.)
►

Sign in to add a comment