GN check fails: content_unittests missing dep media/blink |
||
Issue description
content_unittests is missing a dep when enable_webrtc is false
ERROR at //content/renderer/media/html_audio_element_capturer_source_unittest.cc:14:11: Can't include this header from here.
#include "media/blink/webaudiosourceprovider_impl.h"
^----------------------------------------
The target:
//content/test:content_unittests
is including a file from the target:
//media/blink:blink
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//content/test:content_unittests -->
//content/renderer:for_content_tests -->
//content/renderer:renderer --[private]-->
//media/blink:blink
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65250ec7ef20e67d5eabb7d7857a124f6918694b commit 65250ec7ef20e67d5eabb7d7857a124f6918694b Author: mbjorge <mbjorge@chromium.org> Date: Tue Sep 06 18:30:14 2016 Fix gn check in content_unittest when enable_webrtc=false BUG= 643904 TEST=gn check Change-Id: Ia57a7f4e9df39e117cb7995cc1ab931fc854be32 Review-Url: https://codereview.chromium.org/2309003002 Cr-Commit-Position: refs/heads/master@{#416677} [modify] https://crrev.com/65250ec7ef20e67d5eabb7d7857a124f6918694b/content/test/BUILD.gn
,
Sep 6 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mbjorge@chromium.org
, Sep 3 2016