New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643886 link

Starred by 1 user
Status: Assigned
Owner:
█ gfhuang@chromium.org
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No way to get locale-specific data from resource_bundle.h

Project Member Reported by gfhuang@chromium.org, Sep 3 2016 
I can follow 

"Language-Specific Graphics (or Other Included Resources)"
in https://www.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-guide

to add language specific data into the .pak

however, I have no way to receive it from resource_bundle.h API
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bbbe9e7582e2e269471741234da72c09288d1da

commit 2bbbe9e7582e2e269471741234da72c09288d1da
Author: gfhuang <gfhuang@chromium.org>
Date: Wed Sep 07 00:11:55 2016

[chromecast] Add ResourceBundle::LoadLocalizedResourceBytes() to get binary data from locale_resources_data_.

Also fix an crash in web_ui_data_source_impl that GetDataResourceBytes() could return nullptr.

BUG=643886

Review-Url: https://codereview.chromium.org/2311223003
Cr-Commit-Position: refs/heads/master@{#416787}

[modify] https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da/chromecast/common/cast_content_client.cc
[modify] https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da/content/browser/webui/web_ui_data_source_impl.cc
[modify] https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/2bbbe9e7582e2e269471741234da72c09288d1da/ui/base/resource/resource_bundle.h

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment