New issue
Advanced search Search tips

Issue 643859 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.5% regression in media.android.tough_video_cases at 414470:414511

Project Member Reported by w...@chromium.org, Sep 2 2016

Issue description

ChromiumPerf/android-nexus5X/media.android.tough_video_cases / vm_proportional_set_size_delta / crowd.ogg_gpu
 

Comment 1 by w...@chromium.org, Sep 2 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=643859

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_sebugkM


Bot(s) for this bug's original alert(s):

android-nexus5X
Cc: ericrk@chromium.org
Owner: ericrk@chromium.org

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Re-enable program memory cache for Adreno 4/5xx
Author  : ericrk
Commit description:
  
The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG= 598060 , 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2267163003
Cr-Commit-Position: refs/heads/master@{#414490}
Commit  : 30bcb92ee59a6778c4025081d7da82d2af8cccc2
Date    : Thu Aug 25 18:49:45 2016


===== TESTED REVISIONS =====
Revision         Mean   Std Dev  N  Good?
chromium@414469  300.0  8.3666   5  good
chromium@414480  293.5  14.9108  4  good
chromium@414485  290.8  10.1587  5  good
chromium@414488  300.4  11.8659  5  good
chromium@414489  288.2  15.7544  5  good
chromium@414490  329.4  8.35464  5  bad    <--
chromium@414511  329.2  12.6174  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 643859

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests media.android.tough_video_cases
Test Metric: vm_proportional_set_size_delta/crowd.ogg_gpu
Relative Change: 9.73%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/641
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002588183042526800


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5227258434813952

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by ericrk@chromium.org, Sep 13 2016

Status: WontFix (was: Assigned)
This doesn't really surprise me, as the CL in question re-enabled caching, which uses memory. The benefits from the shader cache are quite noticeable in many cases, and this was only disabled due to crashes (not to save memory).

Sign in to add a comment