New issue
Advanced search Search tips

Issue 643852 link

Starred by 1 user
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content_shell_apk.ContentShellShellManagementTest#testMultipleShellsLaunched" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 2 2016 
"org.chromium.content_shell_apk.ContentShellShellManagementTest#testMultipleShellsLaunched" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY29udGVudF9zaGVsbF9hcGsuQ29udGVudFNoZWxsU2hlbGxNYW5hZ2VtZW50VGVzdCN0ZXN0TXVsdGlwbGVTaGVsbHNMYXVuY2hlZAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Sep 3 2016 

Detected 9 new flakes for test/step "org.chromium.content_shell_apk.ContentShellShellManagementTest#testMultipleShellsLaunched". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY29udGVudF9zaGVsbF9hcGsuQ29udGVudFNoZWxsU2hlbGxNYW5hZ2VtZW50VGVzdCN0ZXN0TXVsdGlwbGVTaGVsbHNMYXVuY2hlZAw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Sep 5 2016 

Detected 3 new flakes for test/step "org.chromium.content_shell_apk.ContentShellShellManagementTest#testMultipleShellsLaunched". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY29udGVudF9zaGVsbF9hcGsuQ29udGVudFNoZWxsU2hlbGxNYW5hZ2VtZW50VGVzdCN0ZXN0TXVsdGlwbGVTaGVsbHNMYXVuY2hlZAw. This message was posted automatically by the chromium-try-flakes app.

Comment 3 by magjed@chromium.org, Sep 5 2016

Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
The tests seem to fail on this DCHECK:
DCHECK(output_surface_request_pending_);
in CompositorImpl::OnGpuChannelEstablished, compositor_impl_android.cc:649, https://cs.chromium.org/chromium/src/content/browser/renderer_host/compositor_impl_android.cc?rcl=0&l=649.

From the android log:
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: [15763:15763:0905/010108:2397093800:FATAL:compositor_impl_android.cc(649)] Check failed: output_surface_request_pending_. 
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #00 0x75a925d3 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0052a5d3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #01 0x76235153 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00ccd153
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #02 0x76234497 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00ccc497
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #03 0x76236325 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00cce325
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #04 0x76236469 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00cce469
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #05 0x76235edf /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00ccdedf
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #06 0x760a42d3 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00b3c2d3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #07 0x760a434b /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00b3c34b
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #08 0x75a85119 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0051d119
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #09 0x75a987cf /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005307cf
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #10 0x75a98d3d /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00530d3d
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #11 0x75a98f6f /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00530f6f
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #12 0x75a9a95d /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0053295d
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #13 0x75a9aaa3 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00532aa3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #14 0x414b8bcf /system/lib/libdvm.so+0x0001dbcf
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #15 0x414e9125 /system/lib/libdvm.so+0x0004e125
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #16 0x414c1fe3 /system/lib/libdvm.so+0x00026fe3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #17 0x414c8fa3 /system/lib/libdvm.so+0x0002dfa3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #18 0x414c663b /system/lib/libdvm.so+0x0002b63b
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #19 0x414fb863 /system/lib/libdvm.so+0x00060863
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #20 0x415037c5 /system/lib/libdvm.so+0x000687c5
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #21 0x414c1fe3 /system/lib/libdvm.so+0x00026fe3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #22 0x414c8fa3 /system/lib/libdvm.so+0x0002dfa3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #23 0x414c663b /system/lib/libdvm.so+0x0002b63b
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #24 0x414fb57f /system/lib/libdvm.so+0x0006057f
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #25 0x414e4d0d /system/lib/libdvm.so+0x00049d0d
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #26 0x4015d2b3 /system/lib/libandroid_runtime.so+0x0004d2b3
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #27 0x4015dfd9 /system/lib/libandroid_runtime.so+0x0004dfd9
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #28 0x4002005d /system/bin/app_process+0x0000105d
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #29 0x4005734b /system/lib/libc.so+0x0000e34b
Device(01a6fb5b03305d2a) 09-05 01:01:08.319 15763 15763 F chromium: #30 0x4001fd7f /system/bin/app_process+0x00000d7f

khushalsagar@ - I'm assigning to you since you recently added this check in https://codereview.chromium.org/2190033002.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Sep 6 2016 

Detected 7 new flakes for test/step "org.chromium.content_shell_apk.ContentShellShellManagementTest#testMultipleShellsLaunched". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uY29udGVudF9zaGVsbF9hcGsuQ29udGVudFNoZWxsU2hlbGxNYW5hZ2VtZW50VGVzdCN0ZXN0TXVsdGlwbGVTaGVsbHNMYXVuY2hlZAw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2010e7dd770842c852284502b4503c7843d05ff3

commit 2010e7dd770842c852284502b4503c7843d05ff3
Author: khushalsagar <khushalsagar@chromium.org>
Date: Tue Sep 06 05:45:43 2016

content: Handle OutputSurface requests correctly.

If the compositor goes through a visible, invisible and visible sequence,
we would end up queuing 2 GpuChannelHost requests. In this case, the
OutputSurface request is handled when the first callback runs. So
instead of asserting that there is a pending OutputSurface request when
the response callback for the GpuChannel request runs, early out if the
OutputSurface request was already handled.

BUG= 643852 

Review-Url: https://codereview.chromium.org/2313683004
Cr-Commit-Position: refs/heads/master@{#416589}

[modify] https://crrev.com/2010e7dd770842c852284502b4503c7843d05ff3/content/browser/renderer_host/compositor_impl_android.cc

Comment 6 by vasi...@chromium.org, Sep 6 2016

Labels: -Sheriff-Chromium
Is it fixed?

Comment 7 by khushals...@chromium.org, Sep 6 2016

Status: Fixed (was: Assigned)
This should be fixed.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 1 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c746ff375a2f4b47551c421cc71357a1ef8e4798

commit c746ff375a2f4b47551c421cc71357a1ef8e4798
Author: Khushal <khushalsagar@google.com>
Date: Sat Oct 01 19:03:52 2016

content: Handle OutputSurface requests correctly.

If the compositor goes through a visible, invisible and visible sequence,
we would end up queuing 2 GpuChannelHost requests. In this case, the
OutputSurface request is handled when the first callback runs. So
instead of asserting that there is a pending OutputSurface request when
the response callback for the GpuChannel request runs, early out if the
OutputSurface request was already handled.

BUG= 643852 ,650219

Review-Url: https://codereview.chromium.org/2313683004
Cr-Commit-Position: refs/heads/master@{#416589}
(cherry picked from commit 2010e7dd770842c852284502b4503c7843d05ff3)

Review URL: https://codereview.chromium.org/2386643004 .

Cr-Commit-Position: refs/branch-heads/2840@{#617}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c746ff375a2f4b47551c421cc71357a1ef8e4798/content/browser/renderer_host/compositor_impl_android.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c746ff375a2f4b47551c421cc71357a1ef8e4798

commit c746ff375a2f4b47551c421cc71357a1ef8e4798
Author: Khushal <khushalsagar@google.com>
Date: Sat Oct 01 19:03:52 2016

content: Handle OutputSurface requests correctly.

If the compositor goes through a visible, invisible and visible sequence,
we would end up queuing 2 GpuChannelHost requests. In this case, the
OutputSurface request is handled when the first callback runs. So
instead of asserting that there is a pending OutputSurface request when
the response callback for the GpuChannel request runs, early out if the
OutputSurface request was already handled.

BUG= 643852 ,650219

Review-Url: https://codereview.chromium.org/2313683004
Cr-Commit-Position: refs/heads/master@{#416589}
(cherry picked from commit 2010e7dd770842c852284502b4503c7843d05ff3)

Review URL: https://codereview.chromium.org/2386643004 .

Cr-Commit-Position: refs/branch-heads/2840@{#617}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c746ff375a2f4b47551c421cc71357a1ef8e4798/content/browser/renderer_host/compositor_impl_android.cc
►

Sign in to add a comment