"ios_web_unittests" is flaky |
||||||||
Issue description"ios_web_unittests" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHAsSBUZsYWtlIhFpb3Nfd2ViX3VuaXR0ZXN0cww.
,
Sep 6 2016
,
Sep 6 2016
I don't think we should increase the timeout, that would mask the real issue that this test appears to flakily hang. It's expected to take a few minutes at most. Here are some logs where the test hung with no output until Swarming killed it after almost 20 minutes: https://chromium-swarm.appspot.com/user/task/3111750987c1bc10 https://chromium-swarm.appspot.com/user/task/31052ec8fcce2810 https://chromium-swarm.appspot.com/user/task/31046c1054aa6c10 https://chromium-swarm.appspot.com/user/task/310289a8c9d33a10
,
Sep 6 2016
I've changed the way how LoadHtml works, which is the reason of flakiness. I've already decreased lolling interval, which could fix the problem. If the tests are still flaky then I will change load state polling to waiting for navigation callbacks.
,
Sep 7 2016
,
Sep 7 2016
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aae82276243c4daa1f0604dab1adcf279112229 commit 1aae82276243c4daa1f0604dab1adcf279112229 Author: eugenebut <eugenebut@chromium.org> Date: Wed Sep 07 16:21:24 2016 [ios] Fixed WebTestWithWebState::LoadHtml flakyness. Polling for PAGE_LOADING loadPhase is flaky because the phase can quickly change to PAGE_LOADED in the same runloop cycle. Use WebStateObserver to wait until navigation is committed instead. BUG= 643835 Review-Url: https://codereview.chromium.org/2314933006 Cr-Commit-Position: refs/heads/master@{#416953} [modify] https://crrev.com/1aae82276243c4daa1f0604dab1adcf279112229/ios/web/public/test/web_test_with_web_state.mm
,
Sep 7 2016
Detected 6 new flakes for test/step "ios_web_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHAsSBUZsYWtlIhFpb3Nfd2ViX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.
,
Sep 8 2016
Have not seen any flakes after CL from comment #7 was rolled.
,
Sep 13 2016
,
Sep 13 2016
Still flaky.
,
Sep 14 2016
Detected 5 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.
,
Sep 14 2016
Issue 646684 has been merged into this issue.
,
Sep 15 2016
Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba2a1c1bf73acfc7ceee1a781aa4f2efbf2a2c4 commit fba2a1c1bf73acfc7ceee1a781aa4f2efbf2a2c4 Author: eugenebut <eugenebut@chromium.org> Date: Thu Sep 15 18:48:59 2016 [ios] Reload the page inside WebTestWithWebState::LoadHtml if necessary. Reload the page if script execution fails. Page reload was performed for data URLs and looks like it's also needed for loadHTML:baseURL: API. BUG= 643835 Review-Url: https://codereview.chromium.org/2321843002 Cr-Commit-Position: refs/heads/master@{#418919} [modify] https://crrev.com/fba2a1c1bf73acfc7ceee1a781aa4f2efbf2a2c4/ios/web/public/test/web_test_with_web_state.mm
,
Sep 16 2016
And this time I mean it :)
,
Nov 29
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by magjed@chromium.org
, Sep 5 2016Status: Assigned (was: Untriaged)