New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643819 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove ScopedTracker in //net

Project Member Reported by rsleevi@chromium.org, Sep 2 2016

Issue description

The following query:
https://cs.chromium.org/search/?q=ScopedTracker+file:src/net&sq=package:chromium&type=cs

Shows all uses of tracked_objects::ScopedTracker

During the Perf CY, these were added as CY investigations. However, the Perf team has abandoned this approach, and is no longer looking at this data.

These should all be removed, or, if we believe they represent important places in our loading story, metrics added.
 
A bunch of low-hanging fruit for the next triager :)
Cc: davidben@chromium.org csharrison@chromium.org
Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
mmenke: You are current triager. If any spare time worth taking some of these out. Also cc'ed next two triagers.
Has net team had any use for these trackers in the past? I have seen a few bugs indicating jank but I don't recall seeing anything actionable from them.

In general these seem useful if they work, so I just want to be sure that removing them is the right move.

mmenke: you didn't see any IO thread jank from these metrics from the extensions regression, right? That makes me suspect of the metrics.
Cc: mmenke@chromium.org
Labels: Fixit-Net
Owner: ----
Status: Available (was: Assigned)
I didn't, but only the first 30 seconds (And last 30 seconds?  Shutdown only, maybe?) of the browser's lifetime are included in them, and the issue was with stuff leaked over time, so not surprising.

Chris:  There's no chance I'll have time for this today.  Too many codereviews on my plate.
Do we need to look case by case to see if a metric should be added? If not, may I work on this or is anybody else working on this already?
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
Seems to be done.
https://cs.chromium.org/search/?q=ScopedTracker+&sq=package:chromium&type=cs

Sign in to add a comment