New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643795 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 616324



Sign in to add a comment

Download Home space usage display is confusing

Project Member Reported by dfalcant...@chromium.org, Sep 2 2016

Issue description

The Android Police post suggests that people don't know what "used" or "available" mean in the context of the Download Home UI.

We should investigate other options to make this display clearer.


Play Music shows:

X GB
used by Play Music
XXXXXXXXXXXXXXXXXX===----------

Y OTHER APPS
= PLAY MUSIC
- Z GB free




Android's storage settings says:
X GB
Total used of Y GB
 
unnamed (2).png
102 KB View Download
unnamed (3).png
77.9 KB View Download
Blocking: 616324
Cc: -chrome-downloads@google.com -clank-frontend-downloads@google.com dah...@chromium.org twelling...@chromium.org talo@chromium.org ian...@chromium.org
I've been playing with this locally and I'm just not sure there's a good way do this without changing the strings, especially because the progress bar needs a whole lot of explanation.  It also looks really odd to say "0.06 GB" when we have the string "60MB" available.  I'm going to land some changes and see if I can make the display be usable.

Comment 4 Deleted

One possibility for the progress bar is to use a three-state one like Play Music does.  The screenshot shows dark gray representing "everything except your downloads", blue representing "your downloads", and light gray representing "unused space available for downloads".  The blue and light gray are keyed by the size display's string colors.

The problem is that the blue is practically non-existent given how much other stuff is on the device and how much it can store.

The second screenshot is similar, but tries to explain what "used" actually means and shows a more human readable format for the amount of space occupied by downloads.  Spacing is wonky, but it's more descriptive, at least.

Third screenshot just says that the blue represents "downloads" and puts things in a grid layout to fix spacing and avoid translation problems involving verb pluralization and file sizes, rearranging things.  I like the last one, but I'm but a simple software engineer.
screenshot-018e010b20c96fd2-20160906T110100.png
105 KB View Download
screenshot-018e010b20c96fd2-20160906T112156.png
106 KB View Download
screenshot-018e010b20c96fd2-20160906T120200.png
103 KB View Download
Flipped the ordering of the progress bar and the numbers back to how it was before to use the progress bar as a separator from the filters, but I kept the progress bar tight to the rest of it.

Still looks weird to keep the space display in the same sidebar without any distinction from the filters, though.
screenshot-018e010b20c96fd2-20160906T120829.png
105 KB View Download

Comment 7 by carl...@google.com, Sep 6 2016

My "also a simple SWE" feedback:
- If we want to show all 3 bar colors we should add text for all of them in the same color as them. I find it confusing that there is the dark bar there for "all other stuff" but not text for it.
- As for the small size of the blue download-used-space bar, we could set minimum length values for the bars. Yes they wouldn't be as precise but IMO the gain in readability would be more important.
Starts to feel a bit cluttered, but setting the blue part to be at least 1% of the total length does keep it visible.
screenshot-071dccc3439d09bd-20160906T133344.png
85.8 KB View Download
screenshot-018e010b20c96fd2-20160906T133344.png
111 KB View Download
Cc: -rachelis@chromium.org dfalcant...@chromium.org
Owner: rachelis@chromium.org
Assigning this to Rachel to put it into her radar.
Ping?
Sorry - I'm about a week behind after the Chrome UX convergence. This hasn't fallen off the radar.
:( Yes, it's a bit cluttered. I'll have a look at this as soon as I can.
Jon and I are chatting - a sidebar is that we shouldn't use GB if we have less than 1 used. Would it be possible to change that model from the current one to showing KB if there's less than 1MB, and then MB if there's less than 1 GB?
Yeah, I switched to that because it had come up in discussion that showing "bytes" was not preferred when there was nothing downloaded.  That's why the mocks above don't use the arbitrary GB requirement.
Labels: -M-54 M-56
Dan, huge props for all the visual explorations. These are really useful for exploring the problem. Rachel and I agree with your statement that all of these are dissatisfying in some way. It is really tough to explain all the relevant factors in a really small UI treatment. Our opinion is that none of the options are demonstrably better than what we have. Rachelis@ is going to explore some more, but given her schedule and other priorities, we probably won't try to change this for M54 or M55. That said, we should consider the MB/GB string change in the short term. Any objections?
I've been trying to get a decent space display since before M54 branched (see the frontend planning doc).  I don't understand why this needs to be punted to M55, given that we can clarify a lot of things just by changing what the strings represent (e.g. Used -> Downloads and Available showing actual free space instead of the size of the SD card).
I missed the text changes. My apologies. I agree that changing to "used" to "downloads" and showing actual free space vs. sd card size are significant improvements to what we have. Rachel, any objections to those scoped changes?
Bump.
My question here is: how small will we have to make the text in order to fit in the much longer string? (And how will that work will translations?)
Shrinking the text to let the display make sense is a fair trade.  The prototype shots above show how much they had to shrink.  We won't know how these will work with translations, but that depends on how the text is laid out relative to the size (same line vs in a table).
Here's a mock - this is what I understand is the proposed state. Is that correct?


downloads-string-change.png
66.5 KB View Download
Something like that.  These are the immediate proposed changes:

1) Switch from displaying 0.06 GB to 60 MB.
2) Switch "used" to "downloads".
3) Switch what "available" means to show how much free space is left on the device instead of how big storage is.

Where the "downloads" string should go is up to your discretion.  It's clearer than "used" but it doesn't make sense grammatically.
"in downloads" or "of downloads" would make more sense if you're trying to make a sentence, but this is made slightly more complicated by putting it on the same line: we'll need to get translations for the full set of {X KB in Downloads, X MB in Downloads, X GB in Downloads}.  The benefit is that translators can work out proper grammar.
Yes, I agree that the grammar for "XGB Downloads" doesn't really work. One other option might be "downloaded". 

//"in downloads" or "of downloads" would make more sense if you're trying to make a sentence, but this is made slightly more complicated by putting it on the same line: we'll need to get translations for the full set of {X KB in Downloads, X MB in Downloads, X GB in Downloads}.  The benefit is that translators can work out proper grammar.

Did we talk about something like this a while back? This strikes me as something that might be a problem to translate the order of.
downloads-string-change.png
66.2 KB View Download
Downloaded doesn't really work because that implies over time, rather than what's listed.

It's a problem for US to translate it if we try to use Android's size formatter and concatenate it with more words because they can be reordered.  If we tell the translators to give us a string with the size modifier built in, we should be fine.

Comment 26 by carl...@google.com, Sep 20 2016

The word "available" also sounds dubious to me: I'm not sure if it means "free space" or "total drive size".

Another suggestion: adding used sizes of each category presented below, right aligned. It might be UI overload but for me it would further clarify the used size presented above. It would also make this screen more useful in itself.
Cc: -dfalcant...@chromium.org
Owner: dfalcant...@chromium.org
This is clearly not a priority.  Taking it back to see what can be landed on my end.
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5ce82e33afe872b6959dc381925666b14a413f

commit 4f5ce82e33afe872b6959dc381925666b14a413f
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Sep 29 21:14:47 2016

[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG= 650451 , 650447 , 643795 

Review-Url: https://codereview.chromium.org/2359763003
Cr-Commit-Position: refs/heads/master@{#421933}

[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Cc: qin...@chromium.org dfalcant...@chromium.org
 Issue 658758  has been merged into this issue.
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01487868d916766b3ea5767e7876b7af09279660

commit 01487868d916766b3ea5767e7876b7af09279660
Author: dfalcantara <dfalcantara@chromium.org>
Date: Mon Oct 31 23:10:30 2016

[Download Home] Make the space display usable

Matches the updated mock linked in the bug, with some liberties.

* Makes the progress bar represent two values: how much space is
  used by other apps and how much is used by downloads.

* Strings are changed to reflect the updated mock.

* Instead of total space, free space is shown.

* Tests are updated to account for the asynchronous nature of
  retrieving how much free space is available.

Screenshot:
https://drive.google.com/open?id=0B8k2SmEN8xS3UXk2ZkVQbWVtc0k

BUG= 643795 

Review-Url: https://codereview.chromium.org/2464473002
Cr-Commit-Position: refs/heads/master@{#428856}

[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/res/drawable/material_progressbar.xml
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/01487868d916766b3ea5767e7876b7af09279660/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Status: Fixed (was: Assigned)
Landed something.  UX can reopen this if they don't like it when they review it.
Attaching the referenced screenshot
screenshot-018e010b20c96fd2-20161028T125543.png
106 KB View Download

Sign in to add a comment