New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643748 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Track prevalence of duplicates in offline page downloads

Project Member Reported by dewittj@chromium.org, Sep 2 2016

Issue description

As part of the downloads home UI we are trying to understand what type of interaction would work best for handling duplicate saved pages.

Today we don't handle duplicates, we just allow multiple copies of a page.

Proposed metrics can be found here:
https://docs.google.com/document/d/1ZwRkOiy6jnLASQ-nabbFG4NC7kqzukC7C-q6Ym7r2Ag/edit#bookmark=id.t5eheley3xtn
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae

commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae
Author: dewittj <dewittj@chromium.org>
Date: Tue Sep 13 19:24:07 2016

[Offline Pages] Adds duplicate detection metrics.

We want to know whether the UI for showing page downloads as starting
is sufficient to let the user know that something is happening.  The
hypothesis is that if users get too many duplicate pages then they aren't
noticing that the pages are getting saved on the first button click.

BUG= 643748 

Review-Url: https://codereview.chromium.org/2314273003
Cr-Commit-Position: refs/heads/master@{#418331}

[modify] https://crrev.com/1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-54
Status: Fixed (was: Started)

Comment 4 by dimu@chromium.org, Sep 14 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 15 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817ad16f5294d584b3814b05c8badb1592eeda2d

commit 817ad16f5294d584b3814b05c8badb1592eeda2d
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Sep 15 00:07:46 2016

[Offline Pages] Adds duplicate detection metrics.

We want to know whether the UI for showing page downloads as starting
is sufficient to let the user know that something is happening.  The
hypothesis is that if users get too many duplicate pages then they aren't
noticing that the pages are getting saved on the first button click.

BUG= 643748 

Review-Url: https://codereview.chromium.org/2314273003
Cr-Commit-Position: refs/heads/master@{#418331}
(cherry picked from commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae)

Review URL: https://codereview.chromium.org/2344713002 .

Cr-Commit-Position: refs/branch-heads/2840@{#371}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817ad16f5294d584b3814b05c8badb1592eeda2d

commit 817ad16f5294d584b3814b05c8badb1592eeda2d
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Sep 15 00:07:46 2016

[Offline Pages] Adds duplicate detection metrics.

We want to know whether the UI for showing page downloads as starting
is sufficient to let the user know that something is happening.  The
hypothesis is that if users get too many duplicate pages then they aren't
noticing that the pages are getting saved on the first button click.

BUG= 643748 

Review-Url: https://codereview.chromium.org/2314273003
Cr-Commit-Position: refs/heads/master@{#418331}
(cherry picked from commit 1e3105ed9096bf45f4ca2d79b4a682adc1d1d9ae)

Review URL: https://codereview.chromium.org/2344713002 .

Cr-Commit-Position: refs/branch-heads/2840@{#371}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/817ad16f5294d584b3814b05c8badb1592eeda2d/tools/metrics/histograms/histograms.xml

Sign in to add a comment