Incorrect paint invalidation on local backgrounds on scrolled overflow scoller. |
||||||||||
Issue descriptionVersion: 55.0.2848.0 If you cause a paint invalidation on a composited overflow scroll element with a locally attached background we issue a paint invalidation at (0, 0) but the actual paint occurs at (-scrollLeft, -scrollTop). This is because we're painting into the scrolling contents layer in the coordinate space of the overflow: scroll element which doesn't include the scroll offset. Patch to fix is here: https://codereview.chromium.org/2307983002
,
Sep 2 2016
Okay, if I modify the test paint/selection/selection-within-composited-scroller.html to have a local background and ensure that it paints the scroller before it scrolls down this consistently crashes for me on tot. I've attached the modified test.
,
Sep 7 2016
Chris, as I understand it you're looking into this bug?
,
Sep 7 2016
+schenney FYI, this is the bug blocking relanding https://codereview.chromium.org/2264663002/ which treats local equivalent backgrounds as local (i.e. lets the gmail scroller be composited with lcd text).
,
Sep 7 2016
Yes. Now I think the bug is not actually in the under-invalidation checking code, but in how we bake composited scrolling into DrawingDisplayItems.
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852 commit 1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852 Author: chrishtr <chrishtr@chromium.org> Date: Sat Sep 10 20:46:32 2016 Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG= 643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2327243002 Cr-Commit-Position: refs/heads/master@{#417843} [modify] https://crrev.com/1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852/third_party/WebKit/Source/core/paint/BoxPainter.cpp
,
Sep 10 2016
Verified that the test in https://codereview.chromium.org/2310203002 no longer has under-invalidation. Closing.
,
Sep 12 2016
This CL needs merging into M54, since the regression happened before the branch point with this patch: https://codereview.chromium.org/2196583002
,
Sep 12 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 12 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) so that we could take this for next Beta Release.
,
Sep 12 2016
Yes.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01ef7cf074bd42e12f56fefa3fb40586b20d3cbd commit 01ef7cf074bd42e12f56fefa3fb40586b20d3cbd Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Sep 12 18:23:35 2016 Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG= 643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2327243002 Cr-Commit-Position: refs/heads/master@{#417843} (cherry picked from commit 1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852) Review URL: https://codereview.chromium.org/2331083002 . Cr-Commit-Position: refs/branch-heads/2840@{#305} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/01ef7cf074bd42e12f56fefa3fb40586b20d3cbd/third_party/WebKit/Source/core/paint/BoxPainter.cpp
,
Sep 12 2016
,
Sep 14 2016
Tested the same on mac 10.11.6 by opening the html file given in comment #2 and observed that there is no crash on scrolling up/down/left/right in the reported version version 55.0.2848.0 as well. Please find the screencast Could you please provide the TEST steps to manually verify the issue from test team end.
,
Sep 14 2016
As per #10 & 11 , marking as verified.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01ef7cf074bd42e12f56fefa3fb40586b20d3cbd commit 01ef7cf074bd42e12f56fefa3fb40586b20d3cbd Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Sep 12 18:23:35 2016 Use a scroll recorder rather than scroll offset for composited-scrolling backgrounds. BUG= 643741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2327243002 Cr-Commit-Position: refs/heads/master@{#417843} (cherry picked from commit 1e64d5cf1fd26c35ffbe26fbaf6d3033a42c9852) Review URL: https://codereview.chromium.org/2331083002 . Cr-Commit-Position: refs/branch-heads/2840@{#305} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/01ef7cf074bd42e12f56fefa3fb40586b20d3cbd/third_party/WebKit/Source/core/paint/BoxPainter.cpp |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by flackr@chromium.org
, Sep 2 2016