test files in chrome/test/data/safe_browsing/download_protection not representative |
||||
Issue descriptionI happened to notice that the test file "wow_helper.exe" in chrome/test/data/safe_browsing/download_protection which is described in the README as "Signed Google Chrome binary from an official build." is now inaccurate since Chrome binaries are now dual signed with both SHA-1 and SHA-256 according to new MS standards. The test data should probably be updated to reflect this. Also, wow_helper.exe is gone now, so potentially pick another binary.
,
Sep 2 2016
+grt@, could you take a look at this one? Since your tests are using this binary : https://codereview.chromium.org/1047693002
,
Sep 4 2016
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/343ce0d06fd55bc35842d2812861f3e733dafe88 commit 343ce0d06fd55bc35842d2812861f3e733dafe88 Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 07 10:15:18 2016 A new test binary for various signature-related tests. BUG= 643733 TBR=nparker@chromium.org Review URL: https://codereview.chromium.org/2320543002 . Cr-Commit-Position: refs/heads/master@{#416899} [add] https://crrev.com/343ce0d06fd55bc35842d2812861f3e733dafe88/chrome/test/data/safe_browsing/download_protection/disable_outdated_build_detector.exe
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08934823edae715752cd5c501c8b56901e760982 commit 08934823edae715752cd5c501c8b56901e760982 Author: grt <grt@chromium.org> Date: Wed Sep 07 11:36:21 2016 Use a new dual-signed binary in safe browsing tests. BUG= 643733 R=wfh@chromium.org Review-Url: https://codereview.chromium.org/2308403002 Cr-Commit-Position: refs/heads/master@{#416909} [modify] https://crrev.com/08934823edae715752cd5c501c8b56901e760982/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc [modify] https://crrev.com/08934823edae715752cd5c501c8b56901e760982/chrome/common/safe_browsing/pe_image_reader_win_unittest.cc [modify] https://crrev.com/08934823edae715752cd5c501c8b56901e760982/chrome/test/data/safe_browsing/download_protection/README [delete] https://crrev.com/098b330a204a365b70d381ca9b3e51a9ca7efc29/chrome/test/data/safe_browsing/download_protection/wow_helper.exe
,
Sep 7 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by vakh@chromium.org
, Sep 2 2016