Change of content style pointing to a SVG URL with multiple entities does not cause a repaint |
||||||||
Issue descriptionChrome Version : 52.0.2743.116 (Official Build) (64-bit) URLs (if applicable) : https://codebin.googleplex.com/#/gkf7fw9pypq Other browsers tested: Chrome Canary: FAIL 55.0.2847.0 (Official Build) canary (64-bit) What steps will reproduce the problem? (1) Open said URL. Click the "Click me" button. What is the expected result? The icon displayed should change from a broken square (Fullscreen) to a triangle (Restore) What happens instead? The icon displayed does not change. Please provide any additional information below. Attach a screenshot if possible. Opening DevTools and toggling the "content" style makes the icon update correctly.
,
Sep 3 2016
,
Sep 8 2016
Looks like fragments are ignored for image urls. Over th the svg & image teams for further triage.
,
Sep 8 2016
Anyone on the team know what might be causing this? Could be a straight up invalidation bug too.
,
Sep 8 2016
The example uses Google internal links. I'll try to sanitize it, as the problem is not inherently Google specific.
,
Sep 8 2016
Possibly because StyleImage operator== only compares .data() (which is the ImageResource - which will be the same regardless of the fragment identifier.)
,
Sep 8 2016
Does the following match the issue? (Loaded from HTTP, because file: have some special-cases when it comes to loading.)
,
Sep 8 2016
The effect appears the same to me.
,
Sep 8 2016
Probably the same, but I see what you mean by needing to load from http. It doesn't repro loading from file. Here's the original report code, with internal google URL refs switched to local.
,
Sep 14 2016
,
Sep 26 2016
Even though the url in the OP is not public, this bug has no nonpublic information so we can remove a restrict-view label.
,
Jan 20 2017
Issue 683065 has been merged into this issue.
,
Nov 16 2017
Issue 785998 has been merged into this issue.
,
Aug 14
Issue 873656 has been merged into this issue.
,
Sep 4
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8468d5775293357816e12d37e26dcf02d5dd04e5 commit 8468d5775293357816e12d37e26dcf02d5dd04e5 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Sep 06 10:17:34 2018 Rework StyleImage equality determination StyleFetchedImage and StyleFetchedImageSet needs to take the URL into consideration because it can contain a fragment that will require the image to change. Bug: 643716 Change-Id: If87d3583df0fcb37f872c1423a88f4bd33e8c38f Reviewed-on: https://chromium-review.googlesource.com/1207390 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589128} [add] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/WebKit/LayoutTests/http/tests/images/image-fragment-id-invalidation-expected.html [add] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/WebKit/LayoutTests/http/tests/images/image-fragment-id-invalidation.html [add] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/WebKit/LayoutTests/http/tests/images/resources/sprites.svg [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_fetched_image.cc [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_fetched_image.h [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_fetched_image_set.cc [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_fetched_image_set.h [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_generated_image.cc [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_generated_image.h [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_image.h [modify] https://crrev.com/8468d5775293357816e12d37e26dcf02d5dd04e5/third_party/blink/renderer/core/style/style_pending_image.h
,
Sep 6
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dtapu...@chromium.org
, Sep 2 2016