Reloading of chrome://cast page always takes user to the device list |
|||||
Issue descriptionVersion: M53 OS: Mac, Windows, ChromeOS (1) Go to chrome://cast with at least one Cast device connected and set up. (2) Click on the gear icon on the device's card and navigate into device settings. (3) Reload the page. What is the expected output? The page should reload to display the settings of the device. What do you see instead? The page reloads and goes back to the device list.
,
Sep 6 2016
Requesting merge into M54: change only affects chrome://cast page and fixes a major usability issue with the page.
,
Sep 6 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d129413c7f353d8e2e07409fa049271e4ba94b71 commit d129413c7f353d8e2e07409fa049271e4ba94b71 Author: Derek Cheng <imcheng@chromium.org> Date: Tue Sep 06 22:35:15 2016 Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG= 643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2303133002 Cr-Commit-Position: refs/heads/master@{#416311} (cherry picked from commit e371fb2dc6cce53e784870abe6a959600a66db4e) Review URL: https://codereview.chromium.org/2317723004 . Cr-Commit-Position: refs/branch-heads/2840@{#187} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d129413c7f353d8e2e07409fa049271e4ba94b71/chrome/browser/resources/cast/cast.js
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d129413c7f353d8e2e07409fa049271e4ba94b71 commit d129413c7f353d8e2e07409fa049271e4ba94b71 Author: Derek Cheng <imcheng@chromium.org> Date: Tue Sep 06 22:35:15 2016 Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG= 643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2303133002 Cr-Commit-Position: refs/heads/master@{#416311} (cherry picked from commit e371fb2dc6cce53e784870abe6a959600a66db4e) Review URL: https://codereview.chromium.org/2317723004 . Cr-Commit-Position: refs/branch-heads/2840@{#187} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d129413c7f353d8e2e07409fa049271e4ba94b71/chrome/browser/resources/cast/cast.js
,
Sep 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d129413c7f353d8e2e07409fa049271e4ba94b71 commit d129413c7f353d8e2e07409fa049271e4ba94b71 Author: Derek Cheng <imcheng@chromium.org> Date: Tue Sep 06 22:35:15 2016 Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG= 643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2303133002 Cr-Commit-Position: refs/heads/master@{#416311} (cherry picked from commit e371fb2dc6cce53e784870abe6a959600a66db4e) Review URL: https://codereview.chromium.org/2317723004 . Cr-Commit-Position: refs/branch-heads/2840@{#187} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d129413c7f353d8e2e07409fa049271e4ba94b71/chrome/browser/resources/cast/cast.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 2 2016