New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643694 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.1%-7.3% regression in webrtc_perf_tests at 14014:14014

Project Member Reported by ivoc@chromium.org, Sep 2 2016

Issue description

See graphs below.
 

Comment 1 by ivoc@chromium.org, Sep 2 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=643694

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkdKBswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkdC5owkM


Bot(s) for this bug's original alert(s):

webrtc-mac-large-tests

Comment 2 by ivoc@chromium.org, Sep 2 2016

Cc: ivoc@chromium.org
Labels: -M-52 M-55
Owner: perkj@chromium.org
Hi Per, It looks like there was a regression on mac in encode perf stats, and it looks like it was caused by your revert CL: https://codereview.webrtc.org/2250123002
Could you have a look to see if this is expected?

Comment 3 by perkj@chromium.org, Sep 15 2016

Cc: tommi@chromium.org mflodman@chromium.org
So the metric measure how long time it take to encode a frame on average compared to the input frame rate. 

This cl replaces a platform_thread that indeed ran with high priority and was replaced with a tq that does not set thread priorities. 

This regression only seems to be noticeable on Mac on IOS where we use threads from grand central.
I think this is acceptable. 


It would be interesting to see if the difference gets larger with increased load as well.

Comment 5 by perkj@chromium.org, Sep 16 2016

There does not seem to be any tests with higher load on mac but there are with lower load.
https://chromeperf.appspot.com/report?sid=ba15b1f4f71ba150a9ed470823ab48d9d80c2146748bfaed587d6c8ee08b238b&rev=14014


It is also possible to set priorites on gcd queues.... But I wonder if we really want to run the encoder with higher priority than other things.

https://developer.apple.com/library/content/documentation/General/Conceptual/ConcurrencyProgrammingGuide/OperationQueues/OperationQueues.html#//apple_ref/doc/uid/TP40008091-CH102-SW7

Comment 6 by perkj@chromium.org, Nov 4 2016

Status: WontFix (was: Assigned)
Working as intended. We now run the encoder on normal thread priority.

Sign in to add a comment