New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643686 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Show Play Icon always in launcher

Project Member Reported by khmel@chromium.org, Sep 2 2016

Issue description

Inner bug: b/31242721

Make Play Store app list item persistent in app launcher.
 

Comment 1 by khmel@chromium.org, Sep 6 2016

CL: 2308643002
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb325645bf768c7c83a7008f40c07ec5b29de8a

commit ffb325645bf768c7c83a7008f40c07ec5b29de8a
Author: khmel <khmel@chromium.org>
Date: Wed Sep 07 16:42:47 2016

arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG= 643686 
TEST=Manually on device.

Review-Url: https://codereview.chromium.org/2308643002
Cr-Commit-Position: refs/heads/master@{#416965}

[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_launcher.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_launcher.h
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_app_utils.h
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 3 by khmel@chromium.org, Sep 7 2016

Labels: Merge-Request-53 Merge-Request-54
This feature is targeted to M53.

Comment 4 by dimu@chromium.org, Sep 8 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.

Comment 5 by dimu@chromium.org, Sep 8 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 6 by dimu@chromium.org, Sep 8 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.
Cc: bhthompson@chromium.org
Labels: -Hotlist-Merge-review -Merge-Review-53 Merge-Request-Approved-53
This appears to be ARC specific, merge approved.
Labels: -Merge-Request-Approved-53 Merge-Approved-53
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 9 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a902426846380b3536d7ea5a71c947e6c73cb250

commit a902426846380b3536d7ea5a71c947e6c73cb250
Author: khmel <khmel@chromium.org>
Date: Fri Sep 09 17:30:45 2016

[Merge-M53] arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG= 643686 
TEST=Manually on device.

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2308643002
Cr-Commit-Position: refs/heads/master@{#416965}

(cherry picked from commit ffb325645bf768c7c83a7008f40c07ec5b29de8a)

Review-Url: https://codereview.chromium.org/2329513002
Cr-Commit-Position: refs/branch-heads/2785@{#863}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_launcher.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_launcher.h
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_app_utils.h
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/a902426846380b3536d7ea5a71c947e6c73cb250/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 9 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d7d31dce4d7469896c982b17e00d086014ff3c

commit 81d7d31dce4d7469896c982b17e00d086014ff3c
Author: khmel <khmel@chromium.org>
Date: Fri Sep 09 20:51:19 2016

[Merge-M54]  arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG= 643686 
TEST=Manually on device.

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2308643002
Cr-Commit-Position: refs/heads/master@{#416965}

(cherry picked from commit ffb325645bf768c7c83a7008f40c07ec5b29de8a)

Review-Url: https://codereview.chromium.org/2330563002
Cr-Commit-Position: refs/branch-heads/2840@{#280}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_launcher.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_launcher.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_utils.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d7d31dce4d7469896c982b17e00d086014ff3c

commit 81d7d31dce4d7469896c982b17e00d086014ff3c
Author: khmel <khmel@chromium.org>
Date: Fri Sep 09 20:51:19 2016

[Merge-M54]  arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG= 643686 
TEST=Manually on device.

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2308643002
Cr-Commit-Position: refs/heads/master@{#416965}

(cherry picked from commit ffb325645bf768c7c83a7008f40c07ec5b29de8a)

Review-Url: https://codereview.chromium.org/2330563002
Cr-Commit-Position: refs/branch-heads/2840@{#280}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_launcher.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_launcher.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_app_utils.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/app_list/arc/arc_default_app_list.h
[modify] https://crrev.com/81d7d31dce4d7469896c982b17e00d086014ff3c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Sign in to add a comment