There was a discussion of a possibility to improve suggest performance, HQP in particular: https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/vector$20based/chromium-dev/4uQMma9vj9w/HaQ-WvMOAwAJ In order to try to improve performance, we've got to have a benchmark for omnibox. Deleting a popular url is a good benchmark for a discussed improvement.
https://codereview.chromium.org/2300323003/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d7c15ee9c7481355f4b42315d386b0eccc9fd75 commit 7d7c15ee9c7481355f4b42315d386b0eccc9fd75 Author: dyaroshev <dyaroshev@yandex-team.ru> Date: Fri Nov 04 08:51:04 2016 Performance tests for HistoryQuickProvider. This CL adds performance test for HQP: typing and erasing a popular url (10000 similar entries). Based on HQP unittests. BUG= 643668 Review-Url: https://codereview.chromium.org/2300323003 Cr-Commit-Position: refs/heads/master@{#429835} [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/BUILD.gn [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/history/core/browser/history_database.h [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/history/core/browser/history_service.h [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/BUILD.gn [add] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/fake_autocomplete_provider_client.cc [add] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/fake_autocomplete_provider_client.h [add] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/history_quick_provider_performance_unittest.cc [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/history_quick_provider_unittest.cc [add] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/history_test_util.cc [add] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/history_test_util.h [modify] https://crrev.com/7d7c15ee9c7481355f4b42315d386b0eccc9fd75/components/omnibox/browser/in_memory_url_index.h
Are there other tests you intend to add or think should be added, or should we close this issue?
No, I don't have such plans. Feel free to close.
Comment 1 by mmenke@chromium.org
, Sep 2 2016